Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix to as_dict and from_dict in StructureMatcher #1850

Merged
merged 8 commits into from
May 25, 2020

Conversation

lbluque
Copy link
Contributor

@lbluque lbluque commented May 23, 2020

Summary

Include a summary of major changes in bullet points:

  • Saves missing attributes in StructureMatcher.as_dict so that StuctureMatcher.from_dict can faithfully recreate the original object.

Checklist

Work-in-progress pull requests are encouraged, but please put [WIP]
in the pull request title.

Before a pull request can be merged, the following items must be checked:

@shyuep
Copy link
Member

shyuep commented May 25, 2020

Thanks.

@shyuep shyuep merged commit 61ab1ed into materialsproject:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants