Updates to LobsterSet #1928
Merged
Updates to LobsterSet #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry about that, adding an additional rule to ignore in the linter, and accidentally over-rode the default ignore list thereby triggering a lot of errors. It should be fixed now if you merge in the latest master. |
|
No worries - should have looked at the latest testss before starting with this pull request. I hope all tests run through now. Best, |
|
Thanks @JaGeo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have just updated some values in the LobsterSet. Let me know if I should include more tests.
There seem to be problems with the linting in the current main branch. I don't really want to fix all of them - there seem to be hundreds.
I will fix every failing test that seems to be related to my changes.
Best,
JG