Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Species rename #1963

Merged
merged 6 commits into from Sep 29, 2020
Merged

Species rename #1963

merged 6 commits into from Sep 29, 2020

Conversation

shyuep
Copy link
Member

@shyuep shyuep commented Sep 25, 2020

Summary

Include a summary of major changes in bullet points:

  • Rename Specie and DummySpecie to Species and DummySpecies
  • Specie and DummySpecie is allowed as a mapping for backwards compatibility.
  • Corresponding changes to doc where possible.
  • Pylint does not pass because of refactoring in chemenv and defects and abinit packages. These are unrelated to the changes made.

Additional dependencies introduced (if any)

TODO (if any)

Checklist

Work-in-progress pull requests are encouraged, but please put [WIP]
in the pull request title.

Before a pull request can be merged, the following items must be checked:

@shyuep
Copy link
Member Author

shyuep commented Sep 25, 2020

@mkhorton Pls review.

@mkhorton
Copy link
Member

I'm fine merging this since the original Specie and DummySpecie are not deprecated but will remain as simple subclasses, so net disruption to the end user should be minimal.

However, I'm mixed overall since it seems like the change doesn't produce net benefit, but will result in e.g. schemas becoming more complicated, teaching materials becoming out of date. I'm more of a lingustic descriptivist than a prescriptivist, so although I concede the original usage has always been technically incorrect, that doesn't necessarily mean it's wrong.

@shyuep shyuep merged commit 128264a into master Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants