Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support combining data with multiple mol-id #2157

Merged
merged 6 commits into from Jun 1, 2021
Merged

Support combining data with multiple mol-id #2157

merged 6 commits into from Jun 1, 2021

Conversation

htz1992213
Copy link
Contributor

@htz1992213 htz1992213 commented May 29, 2021 •
edited

Summary

Include a summary of major changes in bullet points:

  • Feature 1: Support combining data files that have multiple molecules (mol id) in a single data object
  • Feature 2: Added restriction to LAMMPS data name list for easier parsing.
  • Fix 1: Changed maintainer
  • Fix 2: Linting errors in other modules

@coveralls
Copy link

coveralls commented May 29, 2021 •
edited

Coverage Status

Coverage decreased (-0.6%) to 83.078% when pulling 3a90f50 on htz1992213:master into 37da271 on materialsproject:master.

@mkhorton
Copy link
Member

mkhorton commented Jun 1, 2021

Thanks @htz1992213!

@mkhorton mkhorton merged commit 662a6e3 into materialsproject:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@htz1992213 @coveralls @mkhorton