Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QChem: detect NLebdevPts error in QCOutput #2165

Merged
merged 1 commit into from Jun 17, 2021

Conversation

rkingsbury
Copy link
Contributor

@rkingsbury rkingsbury commented Jun 6, 2021

Summary

Detect need to increase the array of NLebdevPts error in QCOutput that can occur when computing RESP charges. Detecting this error is necessary to enable a handler in custodian. See custodian #170

@rkingsbury
Copy link
Contributor Author

Note that there seems to be a new pylint error causing linting to fail on all PRs

************* Module pymatgen.entries.computed_entries
pymatgen/entries/computed_entries.py:700:8: E1101: Instance of 'ComputedStructureEntry' has no '_composition' member (no-member)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 83.079% when pulling 7ff37b4 on rkingsbury:qcoutput_lebdevpts into 463e4f1 on materialsproject:master.

@shyuep
Copy link
Member

shyuep commented Jun 11, 2021

You can try to fix this error? Technically, there should be a _compositon variable. If not, if you are sure this is purely a linter issue, you can set the ignore.

@mkhorton
Copy link
Member

@shyuep this is not related to this PR, this is a pre-existing issue. I've taken a look at it already + will fix soon. I think it's just started appearing in logs because mypy is getting smarter.

@mkhorton mkhorton merged commit df22c1a into materialsproject:master Jun 17, 2021
@mkhorton
Copy link
Member

Thanks @rkingsbury! Have merged since linter issue was unrelated to this PR and otherwise looks good. Will try to get linters passing in the main branch again soon.

@rkingsbury rkingsbury deleted the qcoutput_lebdevpts branch July 15, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants