Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid error exit for ALGO=CHI #2171

Merged
merged 3 commits into from Jun 13, 2021
Merged

Avoid error exit for ALGO=CHI #2171

merged 3 commits into from Jun 13, 2021

Conversation

KazMorita
Copy link
Contributor

Summary

  • Added ALGO=CHI in place of ALGO=BSE to avoid the code from error exiting.
  • This change is minor, so no change to the document is required.

Additional dependencies introduced (if any)

  • non

TODO (if any)

  • non

@shyuep
Copy link
Member

shyuep commented Jun 10, 2021

Can you add a simple unittest for this? Thanks.

@coveralls
Copy link

coveralls commented Jun 10, 2021 •
edited

Coverage Status

Coverage decreased (-0.6%) to 83.083% when pulling 180153d on KazMorita:master into afa2cb9 on materialsproject:master.

@KazMorita
Copy link
Contributor Author

Can you add a simple unittest for this? Thanks.

I added a file, "test_files/vasprun.xml.chi.gz", and implemented a test to read it.
Please check.

@shyuep shyuep merged commit 0633fb6 into materialsproject:master Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KazMorita @shyuep @coveralls