Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configured test files dir #2224

Merged

Conversation

drew-parsons
Copy link
Contributor

@drew-parsons drew-parsons commented Aug 23, 2021

Summary

  • use PymatgenTest.TEST_FILES_DIR with all tests

Required to enable tests to run separately from the source, for instance for CI testing of packaging for Linux distributions,
see #2025

Before a pull request can be merged, the following items must be checked:

  • Code is in the standard Python style. Black is applied.
  • All linting and tests pass (testing against release v2022.0.11

required to enable tests to run separately from the source, for
instance for CI testing of packaging for Linux distributions,
see materialsproject#2025

Adapted from Debian patch use_TEST_FILES_DIR.patch,
https://salsa.debian.org/debichem-team/pymatgen/-/blob/f8f31f359ef846b728006e61272557e73f413b6b/debian/patches/use_TEST_FILES_DIR.patch
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 83.136% when pulling 86f8981 on drew-parsons:configured_test_files_dir into e002969 on materialsproject:master.

@shyuep shyuep merged commit 9251797 into materialsproject:master Aug 23, 2021
@drew-parsons drew-parsons deleted the configured_test_files_dir branch August 24, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants