Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor interface_reactions module, add support for Plotly #2233

Merged
merged 9 commits into from
Sep 8, 2021
Merged

Refactor interface_reactions module, add support for Plotly #2233

merged 9 commits into from
Sep 8, 2021

Commits on Sep 7, 2021

  1. refactor InterfacialReactivity, add GrandPotentialInterfacialReactivity

    @mattmcdermott
    mattmcdermott committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    ade6f16 View commit details
    Browse the repository at this point in the history

  2. Implement plotly plotting for interface reaction, remove duplicate func

    @mattmcdermott
    mattmcdermott committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    835e421 View commit details
    Browse the repository at this point in the history

  3. Fix to GrandPotentialInterfacialReactivity

    @mattmcdermott
    mattmcdermott committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    9d5d9e2 View commit details
    Browse the repository at this point in the history

  4. re-format tests

    @mattmcdermott
    mattmcdermott committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    44ffeee View commit details
    Browse the repository at this point in the history

  5. fix tests, add better typing

    @mattmcdermott
    mattmcdermott committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    378d39e View commit details
    Browse the repository at this point in the history

  6. fix typing bug

    @mattmcdermott
    mattmcdermott committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    4069933 View commit details
    Browse the repository at this point in the history

  7. fix htmlify in chempot_diagram

    @mattmcdermott
    mattmcdermott committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    3c718d4 View commit details
    Browse the repository at this point in the history

  8. re-run black

    @mattmcdermott
    mattmcdermott committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    c7fba86 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. bug fix to accomodate htmlify

    @mattmcdermott
    mattmcdermott committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    8492558 View commit details
    Browse the repository at this point in the history