update docstring of CutOffDictNN - #2278
Merged
Merged
Conversation
Mention behavior when element pairs are not found in the cutoff dict.
5 tasks
Member
|
@chc273 Has fixed some of the NN calculations. I think you can retest your old implementation. |
Contributor
Author
|
Thanks @shyuep - sorry for the delay on my side; a couple of other tasks popped into existence, I'll get to it as soon as I can |
Contributor
Author
|
by the way, this PR can be merged without further ado |
Member
|
Thanks! Sorry for delay here too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up on @mkhorton 's comments