Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove accidentally tracked files and unset executable flag #2296

Merged
merged 2 commits into from
Nov 18, 2021

Conversation

e-kwsm
Copy link
Contributor

@e-kwsm e-kwsm commented Nov 13, 2021

Summary

Subject says it all.

Checklist

Work-in-progress pull requests are encouraged, but please put [WIP]
in the pull request title.

Before a pull request can be merged, the following items must be checked:

  • Code is in the standard Python style. The easiest way to handle this
    is to run the following in the correct sequence on your local machine. Start with running
    black on your new code. This will automatically reformat
    your code to PEP8 conventions and removes most issues. Then run
    pycodestyle, followed by
    flake8.
  • Docstrings have been added in the Google docstring format.
    Run pydocstyle on your code.
  • Type annotations are highly encouraged. Run mypy to type check your code.
  • Tests have been added for any new functionality or bug fixes.
  • All linting and tests pass.

Note that the CI system will run all the above checks. But it will be much more efficient if you already fix most
errors prior to submitting the PR. It is highly recommended that you use the pre-commit hook provided in the pymatgen
repository. Simply cp pre-commit .git/hooks and a check will be run prior to allowing commits.

@mkhorton
Copy link
Member

Good catch @e-kwsm, thank you

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 83.112% when pulling 23c0e07 on e-kwsm:chmod-x into 9276567 on materialsproject:master.

@mkhorton mkhorton merged commit 81df749 into materialsproject:master Nov 18, 2021
@e-kwsm e-kwsm deleted the chmod-x branch November 19, 2021 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants