Skip to content

Add warning if LASPH != True for meta-GGA/hybrid/vdW/+U - #2297

Merged
mkhorton merged 6 commits into
materialsproject:masterfrom
Andrew-S-Rosen:rosen-mixing
Nov 24, 2021
Merged

Add warning if LASPH != True for meta-GGA/hybrid/vdW/+U#2297
mkhorton merged 6 commits into
materialsproject:masterfrom
Andrew-S-Rosen:rosen-mixing

Conversation

@Andrew-S-Rosen

Copy link
Copy Markdown
Member

This PR implements a simple BadInputSetWarning if LASPH = False (or is not set) yet the user is running a meta-GGA/hybrid/DFT+U/vdW-DF calculation.

Warn the user if they haven't set LASPH or set it to False for meta-GGAs/hybrids/vdW
@coveralls

coveralls commented Nov 14, 2021

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.6%) to 83.117% when pulling debcc75 on arosen93:rosen-mixing into 9276567 on materialsproject:master.

@Andrew-S-Rosen Andrew-S-Rosen changed the title Add warning about LASPH for meta-GGA/hybrid/vdW Add warning LASPH != True for meta-GGA/hybrid/vdW/+U Nov 15, 2021
@Andrew-S-Rosen Andrew-S-Rosen changed the title Add warning LASPH != True for meta-GGA/hybrid/vdW/+U Add warning if LASPH != True for meta-GGA/hybrid/vdW/+U Nov 15, 2021
The default of METAGGA is None so might as well keep it that way in the .get() call
@Andrew-S-Rosen
Andrew-S-Rosen marked this pull request as draft November 22, 2021 21:14
@Andrew-S-Rosen
Andrew-S-Rosen marked this pull request as ready for review November 23, 2021 01:15
@mkhorton
mkhorton merged commit 80ab8b7 into materialsproject:master Nov 24, 2021
@mkhorton

Copy link
Copy Markdown
Member

Thanks @arosen93!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants