Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning if LASPH != True for meta-GGA/hybrid/vdW/+U #2297

Merged
merged 6 commits into from
Nov 24, 2021
Merged

Add warning if LASPH != True for meta-GGA/hybrid/vdW/+U #2297

merged 6 commits into from
Nov 24, 2021

Conversation

Andrew-S-Rosen
Copy link
Member

This PR implements a simple BadInputSetWarning if LASPH = False (or is not set) yet the user is running a meta-GGA/hybrid/DFT+U/vdW-DF calculation.

Warn the user if they haven't set LASPH or set it to False for meta-GGAs/hybrids/vdW
@coveralls
Copy link

coveralls commented Nov 14, 2021

Coverage Status

Coverage decreased (-0.6%) to 83.117% when pulling debcc75 on arosen93:rosen-mixing into 9276567 on materialsproject:master.

@Andrew-S-Rosen Andrew-S-Rosen changed the title Add warning about LASPH for meta-GGA/hybrid/vdW Add warning LASPH != True for meta-GGA/hybrid/vdW/+U Nov 15, 2021
@Andrew-S-Rosen Andrew-S-Rosen changed the title Add warning LASPH != True for meta-GGA/hybrid/vdW/+U Add warning if LASPH != True for meta-GGA/hybrid/vdW/+U Nov 15, 2021
The default of METAGGA is None so might as well keep it that way in the .get() call
@Andrew-S-Rosen Andrew-S-Rosen marked this pull request as draft November 22, 2021 21:14
@Andrew-S-Rosen Andrew-S-Rosen marked this pull request as ready for review November 23, 2021 01:15
@mkhorton mkhorton merged commit 80ab8b7 into materialsproject:master Nov 24, 2021
@mkhorton
Copy link
Member

Thanks @arosen93!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants