Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a ChargemolAnalysis command line caller (for DDEC6, CM5 analysis) #2357

Merged
merged 17 commits into from Jan 31, 2022
Merged

Create a ChargemolAnalysis command line caller (for DDEC6, CM5 analysis) #2357

merged 17 commits into from Jan 31, 2022

Conversation

Andrew-S-Rosen
Copy link
Member

@Andrew-S-Rosen Andrew-S-Rosen commented Jan 19, 2022

Purpose

This PR introduces pymatgen.command_line.chargemol_caller with a ChargemolAnalysis class that functions in an analogous way as BaderAnalysis but for DDEC6/CM5 population analyses. It analyzes the output files from Chargemol and can also execute Chargemol on its own given a VASP directory of CHGCAR, AECCAR0, AECCAR2, and POTCAR files. Tests have been added for all user-facing functions with NaCl (spin-unpolarized) and O3 (spin-polarized) test systems. The only place a test wasn't added was for the execution of Chargemol, as it requires Pymatgen to have the same license if we were to integrate the binary into the Pymatgen repo.

Currently, the ChargemolAnalysis class can return: partial atomic charges (both DDEC and CM5), spin moments (if a spin-polarized calculation was run), dipoles, the sum of bond orders, a bond order mapping between every pair of atoms (including the spin-polarization of those bonds), and R^2/R^3/R^4 moments. Currently, the ChargemolAnalysis is written to be compatible with VASP, but it should only require minor updates if someone wanted to make it compatible with other codes (e.g. Gaussian, CP2K).

Minimal Example

from pymatgen.command_line.chargemol_caller import ChargemolAnalysis

path = "/path/to/my/vasp/run" 
ca = ChargemolAnalysis(path)
print(ca.summary)

which would return

{
    "ddec": {
                "partial_charges": List[float],
                "spin_moments": List[float],
                "dipoles": List[float],
                "rsquared_moments": List[float],
                "rcubed_moments": List[float],
                "rfourth_moments": List[float],
                "bond_order_sums": List[float],
                "bond_order_dict": Dict
            },
    "cm5": {
                "partial_charges": List[float],
            }
}

Note: This is built off of work originally by @mhsiron (with permission) -- see here for the original. The PR here adds a number of features not available in the original version (e.g. CM5 charges), refactors the code a fair bit, and fixes several bugs (e.g. related to bond orders, data types).

@Andrew-S-Rosen Andrew-S-Rosen marked this pull request as draft January 19, 2022 19:26
@coveralls
Copy link

coveralls commented Jan 19, 2022

Coverage Status

Coverage decreased (-0.7%) to 83.306% when pulling c6d38b1 on arosen93:rosen-ddec into 6753761 on materialsproject:master.

@Andrew-S-Rosen
Copy link
Member Author

Andrew-S-Rosen commented Jan 21, 2022

@oxana-a, @mhsiron -- this is now completed. If you have any feature requests or changes you suggest, please let me know! Thanks to @mhsiron for kicking this one off.

@Andrew-S-Rosen Andrew-S-Rosen marked this pull request as ready for review January 21, 2022 01:18
@Andrew-S-Rosen Andrew-S-Rosen changed the title [WIP] Create a chargemol_caller.py (DDEC6, CM5 analysis) Create a chargemol_caller.py (DDEC6, CM5 analysis) Jan 21, 2022
@Andrew-S-Rosen Andrew-S-Rosen changed the title Create a chargemol_caller.py (DDEC6, CM5 analysis) Create a ChargemolAnalysis command line caller (for DDEC6, CM5 analysis) Jan 21, 2022
@shyuep shyuep merged commit eeb2a91 into materialsproject:master Jan 31, 2022
@shyuep
Copy link
Member

shyuep commented Jan 31, 2022

Great thanks!

@Andrew-S-Rosen Andrew-S-Rosen deleted the rosen-ddec branch January 31, 2022 16:41
nwinner added a commit to nwinner/pymatgen that referenced this pull request Mar 8, 2022
commit 3376f27a9c5a4cac1590169f2212361ab6c94388
Merge: 4b66ebc90 7b27d26b9
Author: Matthew Horton <mkhorton@users.noreply.github.com>
Date:   Wed Mar 2 16:41:24 2022 -0800

    Merge pull request #2450 from munrojm/master

    Add monty `cached_class` to other compatibility schemes

commit 7b27d26b9f8de818b9b0306c80a55bc346d90c1c
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Thu Mar 3 00:31:30 2022 +0000

    [pre-commit.ci] auto fixes from pre-commit.com hooks

    for more information, see https://pre-commit.ci

commit 2ad326e61ef19f62dd9f680e4e910ab023b8c1d9
Author: Jason <jmunro@lbl.gov>
Date:   Wed Mar 2 15:34:37 2022 -0800

    Add cached class to other compat. schemes

commit 4b66ebc908cf8cb0322152d64f7491ccb2a84213
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Wed Mar 2 10:36:49 2022 -0800

    Update reqs

commit 7d79eca034cbb58ec971eb1545ea06fe568f765a
Merge: 3d40b31b0 b7542b69c
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Wed Mar 2 06:43:00 2022 -0800

    Merge pull request #2449 from janosh/actions-checkout-v3

    Bump `actions/checkout` in GitHub CI to v3

commit b7542b69cef567c539e1742d3ad44eea958b2bf5
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Wed Mar 2 11:01:04 2022 +0000

    bump GH CI actions/checkout to v3

commit 3d40b31b076aa10d49dbba59a712348c40ee98d3
Author: Matthew Horton <mkhorton@users.noreply.github.com>
Date:   Mon Feb 28 10:26:59 2022 -0800

    Add additional logic to guard against .pmgrc.yml parsing issue

    Thanks @BryantLi-BLI for reporting

commit 412820112d459b77d84340412e9836ea84ebd5d8
Author: Matthew Horton <mkhorton@users.noreply.github.com>
Date:   Fri Feb 25 18:41:28 2022 -0800

    Remove trailing whitespace

commit 657a01cd7d163484495674f762d7be068776ae06
Author: Matthew Horton <mkhorton@users.noreply.github.com>
Date:   Fri Feb 25 17:37:30 2022 -0800

    Set camera center to origin

    Thanks @mattmcdermott

commit a9678c3107902885e22eb0a4f4736b157cce7be5
Author: Matthew Horton <mkhorton@users.noreply.github.com>
Date:   Fri Feb 25 17:07:29 2022 -0800

    Update changelog for v2022.2.25

commit c70ca529586d848134c2e0e4d9362a0e37d1fdde
Merge: 03e8b9981 961f2cd29
Author: Matthew Horton <mkhorton@users.noreply.github.com>
Date:   Fri Feb 25 10:56:11 2022 -0800

    Merge pull request #2447 from mattmcdermott/cpd_fix

    Fix bug in `ChemicalPotentialDiagram` initialization (interior point), improve default plots

commit 961f2cd298e3b3575d7998f794ca6c72515e1b7e
Author: Matthew McDermott <mcdermott@berkeley.edu>
Date:   Thu Feb 24 23:03:53 2022 -0800

    re-run broken tests

commit 742430ea1efbd3f9819285514edbac2a3959df28
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Fri Feb 25 06:46:37 2022 +0000

    [pre-commit.ci] auto fixes from pre-commit.com hooks

    for more information, see https://pre-commit.ci

commit eb10af1b52fd23d2d374316fbd8f55a2abbd1dfe
Author: Matthew McDermott <mcdermott@berkeley.edu>
Date:   Thu Feb 24 22:43:47 2022 -0800

    fix broken test caused by numerical precision

commit 957038771134a1aff12b57cefb94cd655f9b8880
Author: Matthew McDermott <mcdermott@berkeley.edu>
Date:   Thu Feb 24 15:52:08 2022 -0800

    fix broken test due to sorting of array

commit 8dd710abbdda4ebd71a9c4039628d36cdbb28b40
Author: Matthew McDermott <mcdermott@berkeley.edu>
Date:   Thu Feb 24 15:29:53 2022 -0800

    add warning, clean up typing errors

commit 6cfc8009d7121f02f4ff9fcd8c064f07716e1fdf
Author: Matthew McDermott <mcdermott@berkeley.edu>
Date:   Thu Feb 24 14:53:53 2022 -0800

    Clean up docstrings

commit 27ec945602ad3dc42fac27bdd4cd2c1bf14ecd7d
Author: Matthew McDermott <mcdermott@berkeley.edu>
Date:   Thu Feb 24 12:25:24 2022 -0800

    Add element padding to 2D plot

commit 3e070f7e1380ed56ba6ccf9b630f1209c1b5ebb8
Author: Matthew McDermott <mcdermott@berkeley.edu>
Date:   Thu Feb 24 11:44:28 2022 -0800

    Clean up formatting/layout

commit 3c8fe65de90d7d06ae190271ef0a2db978439400
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Thu Feb 24 01:43:07 2022 +0000

    [pre-commit.ci] auto fixes from pre-commit.com hooks

    for more information, see https://pre-commit.ci

commit cc9491c1d87ed4dd669571be27d9f6fbd37affb9
Author: Matthew McDermott <mcdermott@berkeley.edu>
Date:   Wed Feb 23 17:36:35 2022 -0800

    adjust axis label sizes

commit e85efac61ba2e5f696c1752fad435faa0494f5d3
Author: Matthew McDermott <mcdermott@berkeley.edu>
Date:   Wed Feb 23 17:17:07 2022 -0800

    add element padding for plots, change default min limit for stability

commit 0de7d8f66018743dcf2f0686b6f3a7ffa7840498
Author: Matthew McDermott <mcdermott@berkeley.edu>
Date:   Wed Feb 23 13:54:43 2022 -0800

    fix interior point issue

commit d6d01675f460d5d4bd3864ec54ac2f858fbf465b
Author: Matthew McDermott <mcdermott@berkeley.edu>
Date:   Wed Feb 23 13:34:27 2022 -0800

    update chempot_diagram references

commit 03e8b9981535acace1fc84406c8c027626ebbad4
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Thu Feb 24 10:09:47 2022 -0800

    Fix casting issues due to numpy.

commit d659e63fd9b390efb288f7a0b34e9a83ddd0ddc1
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Thu Feb 24 09:23:44 2022 -0800

    More robust skipping of tests that rely on external websites if the
    websites are down.

commit ef90d530ffb929d612790313bdeb98a3d717c7b7
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Thu Feb 24 09:05:49 2022 -0800

    Update reqs.

commit ece39e5afc5e34b71d6c5b401e1339aa1f6307be
Merge: 90ab10ac9 326af0eb1
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Thu Feb 24 09:05:03 2022 -0800

    Merge pull request #2440 from janosh/pydocstyle

    Add pydocstyle pre-commit hook

commit 90ab10ac91c73accfbed6d2e23e2401ce0a07508
Merge: 17354139f 1217240a8
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Thu Feb 24 09:04:43 2022 -0800

    Merge pull request #2448 from JaGeo/master

    Allow to switch off print of ChemEnv citation

commit 1217240a8df11769879ae5b69e1363884b3de5f2
Author: JaGeo <janine.george@bam.de>
Date:   Thu Feb 24 18:03:38 2022 +0100

    Fix logic error

commit 5b4c154194098e7c3b28bf3c7871582ca0d428ee
Author: JaGeo <janine.george@bam.de>
Date:   Thu Feb 24 17:58:23 2022 +0100

    Change default for printing citation in ChemEnv tool

commit 817eb99cd96793ffdc14cc6180d187c15cdeef61
Author: JaGeo <janine.george@bam.de>
Date:   Thu Feb 24 17:28:17 2022 +0100

    Reformat

commit 8e8380c0063909e3ab1d6a01fda91cf17f0dbcaa
Author: JaGeo <janine.george@bam.de>
Date:   Thu Feb 24 17:19:38 2022 +0100

    allow to switch off ChemEnv citation

commit 17354139fea32145fd001105c46903e250fc6951
Merge: 4547c2516 8427738c3
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Thu Feb 24 06:47:48 2022 -0800

    Merge pull request #2438 from janosh/fix-structure-from-yml

    Fix Structure.from_file() for .yml ext

commit 4547c251693007f86f689db7f9e3df7243436136
Merge: c3f139c8c a66ab854b
Author: Matthew Horton <mkhorton@users.noreply.github.com>
Date:   Wed Feb 23 09:57:27 2022 -0800

    Merge pull request #2410 from arosen93/rosen-gvec

    Allow for float ENCUTs in Wavecar class

commit c3f139c8cd5aa7d55cc09ce56a6177d634355ae8
Merge: 33230669c a3f8f941a
Author: Matthew Horton <mkhorton@users.noreply.github.com>
Date:   Tue Feb 22 15:31:42 2022 -0800

    Merge pull request #2439 from jmmshn/parse_WSWQ

    added wswq parser

commit 33230669c94a4f5802bd12e299e0e4c32ebd0eb8
Merge: 394e0d71b a78eb0ce0
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Mon Feb 21 16:18:17 2022 -0800

    Merge pull request #2441 from janosh/citation

commit a78eb0ce018fd5a10c7bbac7c050c8361e551f41
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Mon Feb 21 20:29:43 2022 +0000

    undo readme cite info removal

commit dfa4cdebdb1bc903dbd3958cffc1d194937ce877
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Mon Feb 21 19:23:51 2022 +0000

    move citation information from readme into CITATION.cff

commit 326af0eb1a1926a398a1f7379c535ce301fa5099
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Mon Feb 21 19:02:12 2022 +0000

    fix all resulting 'D301: Use r""" if any backslashes in a docstring' errors

commit ef7c62681882f1615e8cc6208648be8f179e4c97
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Mon Feb 21 19:01:31 2022 +0000

    add pydocstyle pre-commit hook

commit a3f8f941ab48daaee588de4929573da75ca4c9ce
Author: jmmshn <jmmshn@gmail.com>
Date:   Sun Feb 20 19:08:02 2022 -0800

    added wswq parser
    zip
    test fix

commit 8427738c341d2230647c83e7b3924920f1a1faeb
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Fri Feb 18 21:54:28 2022 +0000

    add test for Structure.from_file("fname.yml")

commit 293628a3ed6f403a83d7b1cd9044c29bf1c339ae
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Fri Feb 18 21:50:08 2022 +0000

    check for both yml and yaml match in Structure.from_file()

commit 7ed4ddf15a844f6e79f10e9e295df899a0e16f27
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Fri Feb 18 21:47:56 2022 +0000

    remove unused raw str specifiers

commit 394e0d71bf1d1025fcf75498cbb16aa3f41ce78c
Merge: df44a5412 f2caba9f5
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Tue Feb 15 15:43:16 2022 -0800

    Merge pull request #2434 from JaGeo/master

    Small changes to Lobster classes

commit f2caba9f57f9a4c17c7379aefacfb792dcb1a2a8
Merge: 18a4dcbe5 df44a5412
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Tue Feb 15 15:43:11 2022 -0800

    Merge branch 'master' into master

commit df44a54129f468e2a506cb3ed674a75b70d344b3
Merge: 6ec393bdf 14df0164b
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Tue Feb 15 09:18:16 2022 -0800

    Merge pull request #2430 from janosh/unpin-dev-reqs

    Remove deprecated structure_2_lmpdata()

commit 14df0164b47f30a047cd362febc18abb01f0277f
Merge: 71fb25011 6ec393bdf
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Tue Feb 15 09:18:05 2022 -0800

    Merge branch 'master' into unpin-dev-reqs

commit 6ec393bdfa5bdbc3548bc47b89b9c9fb159793b5
Merge: 0cf5e2ec8 7a53d56cc
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Tue Feb 15 09:17:31 2022 -0800

    Merge pull request #2432 from janosh/fix-type-annos

    Fix and add some type annotations

commit 0cf5e2ec818e9951f8277864f1b42b7572cdebe7
Merge: 555a78834 c44f0d5c5
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Tue Feb 15 09:17:09 2022 -0800

    Merge pull request #2433 from janosh/fix-struct-apply_operation

    Fix Structure.apply_operation() return val

commit 18a4dcbe59b42ee4cfcbabf591af72c9a723c4f7
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Tue Feb 15 16:49:02 2022 +0000

    [pre-commit.ci] auto fixes from pre-commit.com hooks

    for more information, see https://pre-commit.ci

commit dcca8df0887cc907fc66dc181b182725e6bf2740
Author: JaGeo <janine.george@bam.de>
Date:   Tue Feb 15 17:38:49 2022 +0100

    Use of Loewdin charges possible

commit 88dbf90d70c9d7524723ea5a45c7f3f3301da8e7
Author: JaGeo <janine.george@bam.de>
Date:   Tue Feb 15 17:31:16 2022 +0100

    Small changes lobsterin

commit c44f0d5c547817103fda935e9e400bce285a0f75
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Tue Feb 15 10:54:51 2022 +0000

    [pre-commit.ci] auto fixes from pre-commit.com hooks

    for more information, see https://pre-commit.ci

commit 4b37fb4d289d20e9cf7b59566298fc08bfc1ec77
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Tue Feb 15 10:46:24 2022 +0000

    Structure.apply_operation() says it returns structure but didn't

commit 7a53d56ccbd6086050b7e6f421ae0bbceebfd9d6
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Tue Feb 15 10:38:39 2022 +0000

    [pre-commit.ci] auto fixes from pre-commit.com hooks

    for more information, see https://pre-commit.ci

commit d046df07a51ee8a8dd6e8e749aac170bccee531a
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Tue Feb 15 10:36:36 2022 +0000

    fix Pourbaix casing

commit dcd34566be1cff272a4e87e11aef56f5aef926db
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Mon Feb 14 20:52:05 2022 +0000

    more type hints for class SiteCollection

commit d06b22480512e1858f7fb72e9191fc0bf59b9a6b
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Mon Feb 14 20:29:30 2022 +0000

    fix bad Tuple[single_el] type hints with ellipsis

commit 555a788348d5aa8e1d5fdfa20cffa859ec1e475e
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Mon Feb 14 08:49:32 2022 -0800

    Update reqs.

commit 68ab18250be869cb5e5ec319037446f2cf4269d5
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Mon Feb 14 06:41:55 2022 -0800

    Better error message for atomic_numbers. Fixes #2431

commit 71fb25011e7fff68e66eb79217fcd4bde596ae64
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Sat Feb 12 15:29:27 2022 +0000

    [pre-commit.ci] auto fixes from pre-commit.com hooks

    for more information, see https://pre-commit.ci

commit ec96eac7c7ac8f94c8cdc8c684dfd839cf72e4a0
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Tue Feb 8 10:07:31 2022 +0000

    remove deprecated structure_2_lmpdata in pymatgen/io/lammps/data.py

commit 24ae51487b308c7983238f3a6d4c3cadb5dad641
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Tue Feb 8 10:06:57 2022 +0000

    unpin dev requirements (removes need to update manually since pip auto-installs latest versions)

commit 880eb7125ed626a6f04faab6c43a2219fd35e5d7
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Tue Feb 8 10:06:33 2022 +0000

    re-enable autoflake in pre-commit.ci

commit 3b386bc614778e520f302ee1649e2dd0fb4adc48
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Thu Feb 10 08:11:19 2022 -0800

    Fix imports of yaml

commit cc9dabf49f553fff2700aa514f31a3d17f99b18c
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Thu Feb 10 07:59:47 2022 -0800

    Check for pmgrc existece before attempting to load.

commit c37ba66cce99e93557b5e44d697059e2c93c0869
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Thu Feb 10 07:09:52 2022 -0800

    Update docs

commit 9fbf173df75678aae46adb5cf12e673b20f2fda6
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Thu Feb 10 07:08:39 2022 -0800

    Update changelog.

commit d3e23309210bf3e80711ec3ba43b6a0204301b7d
Merge: a3037a35b 033d91cff
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Thu Feb 10 07:07:44 2022 -0800

    Merge branch 'master' of github.com:materialsproject/pymatgen

commit a3037a35bca7091d67df4cf59e190c3114f92a3a
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Thu Feb 10 07:07:36 2022 -0800

    UPdate CHanglog.

commit 033d91cff2f70371847f5f2376c6669467927a81
Merge: a160fca56 542067ecb
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Thu Feb 10 07:06:10 2022 -0800

    Merge pull request #2427 from jonringer/patch-1

    Move cython to setup_requires

commit 542067ecbd0a5a61416d9942d173da77fd980af5
Author: Jonathan Ringer <jonringer@users.noreply.github.com>
Date:   Wed Feb 9 22:28:57 2022 -0800

    Move cython to setup_requires

commit a160fca5669e95ddb700b1fef0323b58b96532ce
Merge: 55dd46238 cb8b05f48
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Wed Feb 9 08:46:47 2022 -0800

    Merge pull request #2424 from materialsproject/pre-commit-ci-update-config

    [pre-commit.ci] pre-commit autoupdate

commit 55dd46238072c2b7d4578d00639169d1fcd5d6a5
Merge: c1335efbe 045954ceb
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Mon Feb 7 11:54:59 2022 -0800

    Merge pull request #2423 from janosh/pmg-config-backup-flag

    Add --backup flag to pmg config

commit 045954cebceb2464f734a76624b0423b5e034e96
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Mon Feb 7 19:47:01 2022 +0000

    fix pylint err line too long, remove excess blank lines

commit cb8b05f484040dfea3d61d416272aac8e74007ef
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Mon Feb 7 19:08:33 2022 +0000

    [pre-commit.ci] auto fixes from pre-commit.com hooks

    for more information, see https://pre-commit.ci

commit 53f1f3b4f9f1ee18c7dfec9f11d611a3e266c4e6
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Mon Feb 7 19:06:42 2022 +0000

    [pre-commit.ci] pre-commit autoupdate

    updates:
    - [github.com/pre-commit/mirrors-mypy: v0.930 → v0.931](https://github.com/pre-commit/mirrors-mypy/compare/v0.930...v0.931)

commit 3a28742e7711cfa14b688cae2cad411af5092e9a
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Mon Feb 7 15:34:07 2022 +0000

    [pre-commit.ci] auto fixes from pre-commit.com hooks

    for more information, see https://pre-commit.ci

commit 0c71cd3ef6c00562401184b2eaabf8a9a4e7230a
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Mon Feb 7 15:27:05 2022 +0000

    update get_lattice_type() doc string with correct Raises: section

commit 88666339b5891f5d2cec6833e7cbbe04c136df90
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Mon Feb 7 15:26:32 2022 +0000

    add pmg config --backup flag to customize or disable writing a backup file when changing .pmgrc.yaml

commit c1335efbe8fe68f20427a5131dad4a0dc41e59ea
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Mon Feb 7 07:03:13 2022 -0800

    Update docs

commit 87da5d0e2f846ff869b49c8e66bc89d475a1695e
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Mon Feb 7 07:01:59 2022 -0800

    Update changelog

commit a60cd95a4ddf60e0e32d241616ab4f7f6925048e
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Mon Feb 7 06:57:39 2022 -0800

    Attempt to fix overwrite of pmgrc.yaml in MPRester. #2421

commit 44d6070698c97290ccfdd2b0fb7111d1669c1f0f
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Mon Feb 7 06:52:56 2022 -0800

    Remove some redundant code

commit 68d98235310345377876f7c1d79903ed8bd57387
Merge: 81472c124 19a10fcde
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Mon Feb 7 06:45:43 2022 -0800

    Merge branch 'master' of github.com:materialsproject/pymatgen

commit 81472c1245543d479ee3a78edb1ef81157e041ea
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Mon Feb 7 06:44:53 2022 -0800

    Better error message if parsing error occurs for pmgrc.yaml. #2421

commit 19a10fcdea09940b1f46a06ce9193840cc1b0d6a
Merge: 031124864 8ede10492
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Sun Feb 6 19:41:05 2022 -0800

    Merge pull request #2420 from janosh/fix-get-crys-sys

    Ensure SpacegroupAnalyzer.get_crystal_system() raises ValueError on neg space groups

commit a66ab854bac8eb71272d35de2c489197b3e7dd1c
Author: Andrew <asrosen93@gmail.com>
Date:   Sun Feb 6 18:17:00 2022 -0800

    revert CI changes

commit 8ede104926f5cfa46f5772de1332d65577975325
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Sun Feb 6 22:08:42 2022 +0000

    get_crystal_system() better value check

commit c15fc4150fb855567cb58c3091e09b1e04eb48f8
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Sun Feb 6 21:19:23 2022 +0000

    test_get_crystal_system() assert raises on spg = 0

commit a510187014ce5924302a82b56aa62890e31d7888
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Sun Feb 6 21:18:49 2022 +0000

    SpacegroupAnalyzer.get_crystal_system() raise on spg < 1

commit 03112486486c8203991b14dafeb3314a3f3c1ba7
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Sun Feb 6 10:10:58 2022 -0800

    Add missing test file.

commit 151fd396ce71c6ab12700fe8dd03bcd27b2d0920
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Sun Feb 6 09:49:24 2022 -0800

    Fix for parsing Vasprun with bad RANDOM SEED. Fixes #2418

commit 5be91426a3632f92cf17ee8c0379e6b8f2639f75
Merge: 0edacc7ee 07fa71148
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Sat Feb 5 08:45:05 2022 -0800

    Merge pull request #2417 from janosh/no-more-star-imports

    Remove last remaining star imports

commit 07fa7114872fcdb0e46907bfe7cc267a57e223c3
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Sat Feb 5 08:30:47 2022 +0000

    fix pylint import order error

commit 2e9491f7cc9316499cd3f78a11ffafc4451ee15c
Author: Andrew <asrosen93@gmail.com>
Date:   Fri Feb 4 15:44:15 2022 -0800

    Fix test

commit 083d697b8762ce0e862cf460b99c0608cefb5566
Merge: 92173a499 1707011ed
Author: Andrew <asrosen93@gmail.com>
Date:   Fri Feb 4 15:43:32 2022 -0800

    Merge remote-tracking branch 'origin/rosen-gvec' into rosen-gvec

commit 92173a499feb7b52dd8360130fd2f94a03552d2c
Author: Andrew <asrosen93@gmail.com>
Date:   Fri Feb 4 15:43:29 2022 -0800

    Fix test

commit 1707011ed9e2a49b601044a62b1f1a1adaf78f17
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Fri Feb 4 23:25:00 2022 +0000

    [pre-commit.ci] auto fixes from pre-commit.com hooks

    for more information, see https://pre-commit.ci

commit f62b34d6724a96580e33622e9d96b40e92631e6d
Merge: b75fddc8f b6ca9bfa9
Author: Andrew <asrosen93@gmail.com>
Date:   Fri Feb 4 15:05:03 2022 -0800

    Merge remote-tracking branch 'origin/rosen-gvec' into rosen-gvec

commit b75fddc8fd73e41fba9ecfae36035de951bec2e8
Author: Andrew <asrosen93@gmail.com>
Date:   Fri Feb 4 15:05:00 2022 -0800

    Fix test

commit a6f0a723c9087cd368b77e1183f260121e993349
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Fri Feb 4 21:08:39 2022 +0000

    replace monty.os.path.which with stdlib shutil.which

commit 3fb7afbd13ccd7c7c1cc05a02d305753453e6497
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Fri Feb 4 20:49:24 2022 +0000

    remove last remaining star imports

commit b6ca9bfa9a9159b3e8cf6dbbe4c896a672ee9958
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Fri Feb 4 20:15:20 2022 +0000

    [pre-commit.ci] auto fixes from pre-commit.com hooks

    for more information, see https://pre-commit.ci

commit 5eb0f718c12932a54ee2f2290744c2ab49ce7930
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Fri Feb 4 07:26:20 2022 +0000

    Revert "[pre-commit.ci] auto fixes from pre-commit.com hooks"

    This reverts commit bb468f54969e3403dd1c216e2055f289f4aa9cc8.

commit 206e8039b459861c9d28641b6d9c37711b9fa920
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Fri Feb 4 07:26:20 2022 +0000

    Revert "Revert "[pre-commit.ci] auto fixes from pre-commit.com hooks""

    This reverts commit baf52548833423f74c7a98edf4068c6cc2a9270c.

commit a526957492ddc215eec6e99e9a7f039d255f66f0
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Fri Feb 4 07:26:20 2022 +0000

    Revert "[pre-commit.ci] auto fixes from pre-commit.com hooks"

    This reverts commit bb468f54969e3403dd1c216e2055f289f4aa9cc8.

commit d8b59b00e2d03348a2295fe7c218ae157182ffcc
Merge: 812a0dd71 0edacc7ee
Author: Andrew S. Rosen <asrosen93@gmail.com>
Date:   Fri Feb 4 12:12:43 2022 -0800

    Merge branch 'materialsproject:master' into rosen-gvec

commit 0edacc7ee9c640202b12782315facb0967d12822
Merge: f30a32c49 ed9958118
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Fri Feb 4 10:12:22 2022 -0800

    Merge pull request #2415 from janosh/isort

    isort

commit f30a32c4924ca438d3c06d323e82899a14122e09
Merge: df6515c1a c58ed7f67
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Fri Feb 4 09:17:02 2022 -0800

    Merge pull request #2416 from janosh/docs-no-more-py37

    Update docs to say min python is 3.8

commit c58ed7f6766fb19fd5e1cdb8cc3feba31dc71df6
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Fri Feb 4 17:13:57 2022 +0000

    update readme + docs saying pmg still supports py37 to py38

commit ed995811800d6cd1f8fab9aebdde0c1b3679a2b3
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Fri Feb 4 17:04:55 2022 +0000

    fix more codespell-detected typos

commit da706e8e6e7adb8a09f2ea240eaaf329b2726c21
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Fri Feb 4 16:40:15 2022 +0000

    remove known_first_party=pymatgen (is auto-detected)

commit 1858f6350ccc668a54c17e78ee092e9d0f6804da
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Fri Feb 4 16:37:38 2022 +0000

    isort **/*.py

commit 54630f423a97c8ca7b52543a6f753545e9887281
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Fri Feb 4 16:36:46 2022 +0000

    add isort pre-commit hook

commit df6515c1a55835aaee3c530c182e78cd651530a2
Merge: dc69bf7f3 d70d096ae
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Fri Feb 4 08:17:17 2022 -0800

    Merge pull request #2414 from janosh/pre-commit-ci-badge

    pre-commit.ci readme badge

commit dc69bf7f380f8b30e26b4ab3beb5dc9cf85d0134
Merge: 479ea52f7 6a0265363
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Fri Feb 4 08:12:18 2022 -0800

    Merge pull request #2411 from utf/str-fixes

    More string format tidying

commit d70d096ae805a4c030c5f8ade6fda8b588e6973c
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Fri Feb 4 15:34:31 2022 +0000

    leave hooks flake8, autoflake, mypy in place for checking new code locally, only disable in CI

commit 09aeba2d516e7ba5e410a18be6454a9dd40ab1bd
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Fri Feb 4 15:26:12 2022 +0000

    [pre-commit.ci] auto fixes from pre-commit.com hooks

    for more information, see https://pre-commit.ci

commit 6a02653635daea5c7df6d50776102d07ed69c7c1
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Fri Feb 4 15:19:55 2022 +0000

    [pre-commit.ci] auto fixes from pre-commit.com hooks

    for more information, see https://pre-commit.ci

commit fb05aa52b15d72a2880d5fc9871be03bd8fcb034
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Fri Feb 4 15:19:29 2022 +0000

    set pre-commit.ci autoupdate schedule to monthly

commit fbab8fcd7989636a2073f1adcafec2e8873c1715
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Fri Feb 4 15:18:12 2022 +0000

    add pre-commit.ci status badge to readme

commit f46ece56e504a62a9ad71a441df2647af8dd1b81
Author: Alex Ganose <utf@users.noreply.github.com>
Date:   Fri Feb 4 15:14:34 2022 +0000

    Update .pre-commit-config.yaml

commit 59004d0c7a3d503eb80fee8111eee843354c0c21
Merge: 3cc56c0db 479ea52f7
Author: Alex Ganose <utf@users.noreply.github.com>
Date:   Fri Feb 4 15:13:54 2022 +0000

    Merge branch 'master' into str-fixes

commit 479ea52f78644618e2eb7a1107e3f8a69296b14d
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Fri Feb 4 07:13:17 2022 -0800

    Update reqs

commit 04c90fbc8cd08f1a65523e11546cfa977267a3ae
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Fri Feb 4 06:54:54 2022 -0800

    Linting fixes.

commit b15fb785753d118b99ed1ab87a5c439a6cfe398c
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Fri Feb 4 06:50:09 2022 -0800

    Disable autoflake in precommit.

commit d4d4cf7176d400ff770b83eb875acf0f7365058f
Merge: f8f707cc8 73e31e344
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Fri Feb 4 06:49:23 2022 -0800

    Merge branch 'master' of github.com:materialsproject/pymatgen

commit 73e31e34485744de765656dea7c450e304db2815
Merge: e45234a88 338aa705c
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Fri Feb 4 06:49:09 2022 -0800

    Merge pull request #2413 from JaGeo/master

    Update minimal basis

commit 3cc56c0db8402362e54c19307e93c5a666038d0e
Author: Alex Ganose <alexganose@googlemail.com>
Date:   Fri Feb 4 09:39:32 2022 +0000

    Fix broken string

commit 338aa705ce794fe21aa2949dfde9ddca4e471025
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Fri Feb 4 09:20:18 2022 +0000

    [pre-commit.ci] auto fixes from pre-commit.com hooks

    for more information, see https://pre-commit.ci

commit aaa26b5ec137839c6adc86e4143c34c49f352f2c
Author: J. George <JaGeo@users.noreply.github.com>
Date:   Fri Feb 4 10:15:26 2022 +0100

    Update minimal basis

    Be 2p orbitals made problems before ...

commit 812a0dd712149fdd07d1423a51304554f8ba17b9
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Fri Feb 4 07:36:56 2022 +0000

    [pre-commit.ci] auto fixes from pre-commit.com hooks

    for more information, see https://pre-commit.ci

commit baf52548833423f74c7a98edf4068c6cc2a9270c
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Fri Feb 4 07:26:20 2022 +0000

    Revert "[pre-commit.ci] auto fixes from pre-commit.com hooks"

    This reverts commit bb468f54969e3403dd1c216e2055f289f4aa9cc8.

commit bb468f54969e3403dd1c216e2055f289f4aa9cc8
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Fri Feb 4 07:26:20 2022 +0000

    [pre-commit.ci] auto fixes from pre-commit.com hooks

    for more information, see https://pre-commit.ci

commit 0b1c940af08b0cbaae2136795187870de765ee82
Merge: 6ff8026bb e45234a88
Author: Andrew S. Rosen <asrosen93@gmail.com>
Date:   Thu Feb 3 23:23:28 2022 -0800

    Merge branch 'materialsproject:master' into rosen-gvec

commit 6ff8026bba08f639d6e1dc273395cceaa4d789a0
Author: Andrew <asrosen93@gmail.com>
Date:   Thu Feb 3 23:20:47 2022 -0800

    Make sure type is float for ENCUT in WAVECAR

commit 1b41579295692fae68ff383dfda1c05066da1eb5
Author: Andrew <asrosen93@gmail.com>
Date:   Thu Feb 3 23:18:55 2022 -0800

    Add test for fractional ENCUT in WAVECAR

commit f8f707cc8f8f2c828798a27bde48ce51962caf81
Merge: 2c8fcd579 e45234a88
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Thu Feb 3 11:11:37 2022 -0800

    Merge branch 'master' of github.com:materialsproject/pymatgen

commit 2c8fcd579edea6adc480220582d0dbcb7e2ee6a2
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Thu Feb 3 11:11:21 2022 -0800

    Fix black version in pre-commit.

commit e94c360c866167e6766eb8bc363e2f96ca4ca638
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Thu Feb 3 18:41:58 2022 +0000

    [pre-commit.ci] auto fixes from pre-commit.com hooks

    for more information, see https://pre-commit.ci

commit 1696382d251a0740d5feebdd6e302aa0b600df95
Author: Alex Ganose <alexganose@googlemail.com>
Date:   Thu Feb 3 18:41:17 2022 +0000

    Update black and mypy versions in pre-commit yaml

commit 01ccbe1c2cb8789e9c63da488326a29ac31aa0d2
Merge: ae14a1eca e45234a88
Author: Alex Ganose <utf@users.noreply.github.com>
Date:   Thu Feb 3 18:38:35 2022 +0000

    Merge branch 'master' into str-fixes

commit ae14a1eca6515b5f070d24363058d9d04308cddc
Author: Alex Ganose <alexganose@googlemail.com>
Date:   Thu Feb 3 18:37:00 2022 +0000

    Try and use the right version of black

commit e45234a881379b6b2785d3a72e861e68d0587af6
Merge: acef4c810 11e1d8d3b
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Thu Feb 3 09:26:53 2022 -0800

    Merge pull request #2409 from arosen93/rosen-keyerror

    Return None for complete_dos.spin_polarization if ISPIN=1

commit acef4c8108c405b7648bdba10e3249e0e7d3d0f5
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Thu Feb 3 07:40:53 2022 -0800

    Add pre-commit to dev requirements.

commit e0c2d3138b70de358729cca2477931643582e7b8
Merge: e647621dd 02dd8032c
Author: Alex Ganose <alexganose@googlemail.com>
Date:   Thu Feb 3 09:54:52 2022 +0000

    Merge branch 'master' into str-fixes

commit e647621dd12becb6eb89454de93d80b4e2f97670
Author: Alex Ganose <alexganose@googlemail.com>
Date:   Thu Feb 3 09:53:46 2022 +0000

    Fix linting

commit bd77915250e4dec37fb57c884b60e46931404ba4
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Wed Feb 2 17:40:00 2022 -0800

    Update pre-commit instructions.

commit 02dd8032ce435f40fb99b92452a1ca4631b507e6
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Wed Feb 2 17:40:00 2022 -0800

    Update pre-commit instructions.

commit a724860ec144bfc7349c18ec53ead764c355fe19
Author: Alex Ganose <alexganose@googlemail.com>
Date:   Thu Feb 3 00:42:10 2022 +0000

    More fixes

commit f94fc9701bbead37f9acac626ce79410952e820e
Author: Alex Ganose <alexganose@googlemail.com>
Date:   Thu Feb 3 00:32:11 2022 +0000

    More string tidying

commit fa737b5745dc25444365cb2326a4814c43c1ad91
Author: Andrew <asrosen93@gmail.com>
Date:   Wed Feb 2 01:10:28 2022 -0800

    Change type in wavecar test for clarity

commit 74883f2623bfa255fd8f54629a4d664ad38ac135
Author: Andrew <asrosen93@gmail.com>
Date:   Wed Feb 2 01:06:48 2022 -0800

    Fix ENCUT type in Wavecar class (thanks @RyanNKHall)

commit 657b6e9368ac78471870e38ae49de8397d261e2c
Author: Andrew <asrosen93@gmail.com>
Date:   Wed Feb 2 01:03:49 2022 -0800

    Allow for float ENCUTs in Wavecar class

commit 11e1d8d3b0311e73fd3479cf3703b5c3c397ca5f
Author: Andrew <asrosen93@gmail.com>
Date:   Tue Feb 1 22:53:51 2022 -0800

    fix spin_polarization typing

commit 298b318bb92c7547aa23130ce4488535967c89bf
Author: Andrew <asrosen93@gmail.com>
Date:   Tue Feb 1 22:47:59 2022 -0800

    Return None for complete_dos.spin_polarization if ISPIN=1

commit 7f1582fa57650b513bd51f77e09b44f6585c8cc1
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Tue Feb 1 14:17:01 2022 -0800

    Fix bad workflow for release.

commit 216467088bc650015b17ad5f088b7c866b41626a
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Tue Feb 1 13:10:55 2022 -0800

    Black.

commit c9a695f17678cad29fdbf4a1c71af8b55773766c
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Tue Feb 1 13:05:10 2022 -0800

    Minor fix to changelog.

commit aec3ebc9da7d3bf65317ee6c37532dd61eff0651
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Tue Feb 1 13:03:10 2022 -0800

    Update docs

commit 522784fbb805839bbb58fb499edeed567b34eae5
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Tue Feb 1 13:02:06 2022 -0800

    Udpate change log

commit b719c919c95a178dc9813110bfd0574a83ef00e0
Merge: 845e25a92 67beee2a1
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Tue Feb 1 13:01:00 2022 -0800

    Merge branch 'master' of github.com:materialsproject/pymatgen

commit 845e25a9296a58b5f905cee18e2b3e22ceb5881b
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Tue Feb 1 13:00:33 2022 -0800

    Update docs

commit 23e0df0c42d15f870a28fafc54df15f3d2671e9a
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Tue Feb 1 12:59:21 2022 -0800

    Update black.

commit 91d0debe9aca7cb147d958988bcd083ffc304bee
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Tue Feb 1 12:58:35 2022 -0800

    Updated changelog.

commit 67beee2a17bfa38b9b1114ec2df34ab1310a8819
Merge: 6dbdeec11 0632be938
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Tue Feb 1 09:40:15 2022 -0800

    Merge pull request #2407 from espottesmith/qchem_cc

    Improve parsing of coupled-cluster calculations in Q-Chem

commit 0632be938dae90de301a0c93f68fb1ca53f879d7
Author: Evan Walter Clark Spotte-Smith <espottesmith@gmail.com>
Date:   Mon Jan 31 15:20:42 2022 -0800

    black again

commit 8d1c53594caf21d41d20520a2428e2f8c92d404a
Author: Evan Walter Clark Spotte-Smith <espottesmith@gmail.com>
Date:   Mon Jan 31 15:00:43 2022 -0800

    black

commit b94aac6c16aa1437c103513d510ce7e9f529a4b6
Author: Evan Walter Clark Spotte-Smith <espottesmith@gmail.com>
Date:   Mon Jan 31 14:49:46 2022 -0800

    Add structure change data to parsing of PES Scan calculations

commit 7427d4719de259580bf322675fe1ecaa6a24f6a0
Author: Evan Walter Clark Spotte-Smith <espottesmith@gmail.com>
Date:   Mon Jan 31 14:42:32 2022 -0800

    Added CCSD and CCSD(T) parsing to Q-Chem IO

commit 6dbdeec119491f21da88f3bdb7f4c33ee5fe7ff7
Merge: fe8ed155b 433e7d881
Author: Matthew Horton <mkhorton@users.noreply.github.com>
Date:   Mon Jan 31 14:02:08 2022 -0800

    Merge pull request #2343 from arosen93/rosen-group

    Update row and group number for lanthanoids/actinoids

commit fe8ed155b6e1d4d147d6f7f0bbd19a83415c755f
Merge: fedfdd0a6 e8f828d1b
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Mon Jan 31 13:36:09 2022 -0800

    Merge pull request #2405 from janosh/more-deprecation-drops

    Remove more deprecated stuff

commit e8f828d1b5b374017c2f2741cd3aaf7cd5d7fc8f
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Mon Jan 31 21:33:52 2022 +0000

    note recent deprecations and dropping py37 support in docs_rst/compatibility.rst

commit fedfdd0a69b75d9d7890942954a4ffa3604ac4ba
Merge: eeb2a9111 d60d53273
Author: Matthew Horton <mkhorton@users.noreply.github.com>
Date:   Mon Jan 31 12:45:23 2022 -0800

    Merge pull request #2400 from arosen93/rosen-zeo

    Update zeo++ installation steps

commit daf163c0e0ae0de731e8edbe26b15aeaf5ac91b6
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Mon Jan 31 20:10:40 2022 +0000

    fix test_get_products renamed test_products_property

commit 81a1bb5b600c076e8ae6ef402a19c6c11ddb4c98
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Mon Jan 31 16:58:25 2022 +0000

    better pip cache-dependency-path in GHA

commit 9640ec35347a15db230a5b996ba04c1af44d03ce
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Mon Jan 31 19:54:28 2022 +0000

    remove some more old deprecations

commit 433e7d8819cb9a40a98b18e81d434ef85fd4c5a9
Author: Andrew <asrosen93@gmail.com>
Date:   Mon Jan 31 10:31:13 2022 -0800

    Revert breaking change in from_row_and_group

commit d60d53273b721b5d09580552c78bcbae293755be
Author: Andrew <asrosen93@gmail.com>
Date:   Mon Jan 31 09:33:35 2022 -0800

    Fix Zeo++ installation instructions

commit eeb2a9111d6d68ff9b2ec42f2afe59d1181e8af8
Merge: ef5b33c0e c6d38b11d
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Mon Jan 31 08:39:31 2022 -0800

    Merge pull request #2357 from arosen93/rosen-ddec

    Create a ChargemolAnalysis command line caller (for DDEC6, CM5 analysis)

commit ef5b33c0e4e44ab125bf09aa73ea6ee061583eeb
Merge: fcfe61146 e578fca0d
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Mon Jan 31 08:38:43 2022 -0800

    Merge pull request #2399 from arosen93/rosen-asemags

    ASEAtomsAdaptor: magmom/charge site properties in Structure/Molecule become initial (rather than final) magmoms/charges in Atoms object

commit fcfe611463710f7dfa77a53e13a83080bfba9195
Merge: 4753ce59e ce3615803
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Mon Jan 31 08:37:44 2022 -0800

    Merge pull request #2397 from janosh/drop-deprecated

    Delete overdue deprecations

commit 4753ce59e67f3d07e7a126b7cfbaf3c11259e1e9
Merge: 07794afb6 76088c3f1
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Mon Jan 31 08:36:11 2022 -0800

    Merge pull request #2401 from janosh/gha-auto-pip-cache

    Use setup-python automatic pip caching in CI

commit e578fca0d451231cf18cf92c9a17e0353b8b18ce
Author: Andrew <asrosen93@gmail.com>
Date:   Mon Jan 31 00:05:13 2022 -0800

    Fix spelling on some code comments

commit b2b23d228234b138ffa1e2445a9e4828f9b4c509
Author: Andrew S. Rosen <asrosen93@gmail.com>
Date:   Sun Jan 30 15:21:17 2022 -0800

    Fix codecomment linting in ASEAtomsAdaptor

commit 4be3160113b59dd5580475485c9d9e0dc202e34d
Author: Andrew S. Rosen <asrosen93@gmail.com>
Date:   Sun Jan 30 15:15:56 2022 -0800

    Update code comments for ASEAtomsAdaptor

commit 76088c3f1e8512f50f792b753a0ed65c237ac625
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Sun Jan 30 13:14:43 2022 +0000

    setup.py long_desc fix broken links

commit ebc4cd53b2f26669494c5d0f6259b90f7fc56b49
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Sun Jan 30 13:06:20 2022 +0000

    use correct cache-dependency-paths

commit eb1599f1ac2142052e53bb7d10f83eb1465aa36b
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Sun Jan 30 10:16:57 2022 +0000

    missed one

commit e060233439d9738fb5b9e51a8f0c79c2fc336b92
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Sun Jan 30 10:09:12 2022 +0000

    setup-python use auto pip caching

commit f7175b8baf09a7fb8ba423055804e1aea7d6e225
Merge: 51c3cb109 07794afb6
Author: Andrew S. Rosen <asrosen93@gmail.com>
Date:   Sun Jan 30 02:04:25 2022 -0800

    Merge branch 'materialsproject:master' into rosen-zeo

commit 51c3cb109ab4974be18897864b6ceaa4c63aa730
Author: Andrew <asrosen93@gmail.com>
Date:   Sun Jan 30 00:59:02 2022 -0800

    Update zeo++ installation steps

commit ce3615803666b28726e56f1a1fd11c3676b06c60
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Sat Jan 29 18:05:20 2022 +0000

    delete overdue deprecations

commit c5e4e24ceebc3491f0d554836e67d6c68ad6306c
Merge: ea11ee670 07794afb6
Author: Andrew S. Rosen <asrosen93@gmail.com>
Date:   Fri Jan 28 23:10:33 2022 -0800

    Merge branch 'materialsproject:master' into rosen-asemags

commit ea11ee67096d0bb5ca02a1d6d144ac11fcb8a972
Author: Andrew <asrosen93@gmail.com>
Date:   Fri Jan 28 22:43:14 2022 -0800

    Update ASEAtomsAdaptor tests

commit 209db4b70cbb8b1e65bdd9efd9097c2bf949d9f7
Author: Andrew <asrosen93@gmail.com>
Date:   Fri Jan 28 22:17:16 2022 -0800

    Make magmom convention consistent with ASEAtomsAdaptor

commit 07794afb624f7613b3dbcebdf0034cab4c9ee7ea
Merge: 645a79bce 08ff11c43
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Thu Jan 27 12:17:27 2022 -0800

    Merge pull request #2394 from JaGeo/master

    Fix issue with gzipped DOSCAR files in Lobster module

commit 645a79bce73535a0da5fe30b5bfee02ee18b0988
Merge: 72849371a 9c3b416d6
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Thu Jan 27 12:17:06 2022 -0800

    Merge pull request #2395 from samblau/qchem

    Q-Chem Updates

commit 9c3b416d6dd77b94189a8cb4e3a3510375877a34
Author: samblau <samblau1@gmail.com>
Date:   Thu Jan 27 11:40:35 2022 -0800

    Run black

commit dde992dd0a68e3912e4dee076a003a3895678634
Merge: b4f43512f 72849371a
Author: samblau <samblau1@gmail.com>
Date:   Thu Jan 27 11:19:49 2022 -0800

    Merge branch 'master' into qchem

commit 08ff11c436018a2ffd8c8a81fdfd5d0865d83edc
Author: jgeorge <jgeorge@sv2218.zit.bam.de>
Date:   Thu Jan 27 19:43:22 2022 +0100

    apply black

commit 32719b7aae340533b6541bcc3563d0d10f650202
Author: jgeorge <jgeorge@sv2218.zit.bam.de>
Date:   Thu Jan 27 19:22:27 2022 +0100

    fix linting

commit 745c4f8c55f231610249bd81c05c0fcf2b2276a8
Merge: c4df24fd6 72849371a
Author: jgeorge <jgeorge@sv2218.zit.bam.de>
Date:   Thu Jan 27 19:10:56 2022 +0100

    Merge branch 'master' of https://github.com/materialsproject/pymatgen

commit c4df24fd66a2f51c1c14c90ab54b15208db65eb0
Author: jgeorge <jgeorge@sv2218.zit.bam.de>
Date:   Thu Jan 27 18:44:59 2022 +0100

    Fix problem zipped DOSCAR problem in Lobster module

commit 72849371a03ffda519e1f590776001b9076c9cd8
Merge: 85ea9dcc6 4f87d606b
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Thu Jan 27 08:05:58 2022 -0800

    Merge pull request #2391 from janosh/compat.process_entry

    Compat.process_entry

commit 85ea9dcc6fbb77cfe5d2fed1bdc365fd0856e8ee
Merge: f7525fce0 0498587d4
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Thu Jan 27 08:05:20 2022 -0800

    Merge pull request #2392 from janosh/drop-ordered-dict

    Drop OrderedDict

commit f7525fce039293a091374c890ea1ca1bf40aafa8
Merge: a13843919 7fd109a71
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Thu Jan 27 08:04:48 2022 -0800

    Merge pull request #2393 from vorwerkc/qe_kpoints_output

    Write k-point grids to QE input file

commit 7fd109a7143350b5dba492dfb4aa755b5a602d8a
Author: Christian Vorwerk <vorwerk@uchicago.edu>
Date:   Thu Jan 27 08:56:36 2022 -0600

    Remove debugging comment.

commit 8661eeda3952da112f158320955a6b0bb1b2753a
Author: Christian Vorwerk <vorwerk@uchicago.edu>
Date:   Thu Jan 27 08:52:55 2022 -0600

    Prevent workflows for forks again.

commit 0498587d46934de9d6ff20e99da624e5d9e82e57
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Thu Jan 27 14:32:46 2022 +0000

    fix symbol_to_oxinum in pymatgen/io/cif.py

commit 278da04bf01316ce718ee70105fda21b0475de64
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Thu Jan 27 11:35:53 2022 +0000

    fix mypy error in pymatgen/io/lobster/inputs.py

commit 0af8a0c66bd54a3dc83a3f33792d48ca0bf22632
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Thu Jan 27 11:22:37 2022 +0000

    update doc strings mentioning OrderedDict

commit 4348e1de1162ceb9f923505d38a53e22c811fa6c
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Thu Jan 27 11:18:40 2022 +0000

    remove unused sort_dict in pymatgen/util/num.py

commit 7d6110f1c8d5a553010827bae9f6187bc1ed5598
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Thu Jan 27 11:17:47 2022 +0000

    replace OrderedDict with dict which are insertion-ordered anyway in p37+

commit 67df7d627cd3ee9f3fe54cd0f4ae69dbb47c421f
Author: Christian Vorwerk <vorwerk@uchicago.edu>
Date:   Wed Jan 26 18:18:18 2022 -0600

    Re-activate linting and tests

commit b59380d49b808286462e65668b0a3d6cb7a65673
Author: Christian Vorwerk <vorwerk@uchicago.edu>
Date:   Wed Jan 26 18:10:00 2022 -0600

    Fix formatting of kpoints output and add corresponding test.

commit 4f87d606bc831e3294ffa2fd0c0c0a93f80e3d35
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Wed Jan 26 20:49:23 2022 +0000

    ignore type error, add mypy commit hook to catch these errors locally before PR

commit 803c97e4241aeaf00abb1b947820737fa36656d7
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Wed Jan 26 20:30:49 2022 +0000

    use try/except in Compatibility.process_entry() to avoid double work

commit a13843919e6fe57fad7e1056b2af260462bb76cb
Merge: 17ce53597 46e2b3f32
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Wed Jan 26 12:08:28 2022 -0800

    Merge branch 'master' of github.com:materialsproject/pymatgen

commit 17ce5359759130a6e420024aa6a0ce3fa48e2f0d
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Wed Jan 26 10:41:09 2022 -0800

    Fix tests.

commit 46e2b3f32a550be6432716a24ae27a630f6a25b8
Merge: d6dbe43bc 04d7a9918
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Wed Jan 26 10:28:34 2022 -0800

    Merge pull request #2380 from janosh/flynt-aggressive

    flynt --aggressive

commit d6dbe43bcd4aadf6c5505eaef454984c730e33ec
Merge: be0a675cb c4bd7150d
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Wed Jan 26 10:28:13 2022 -0800

    Merge pull request #2385 from janosh/autoflake

    Autoflake

commit be0a675cb38ba35251fcd8207271886a040c48c4
Merge: 420c77530 b706b6560
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Wed Jan 26 10:27:49 2022 -0800

    Merge pull request #2388 from arosen93/rosen-charge

    Store the actual charge and spin_mult in structure.as_dict()

commit c4bd7150de5203a7e3a4c53adda47745ab1f7b6d
Merge: c3592de6d 420c77530
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Wed Jan 26 10:27:27 2022 -0800

    Merge branch 'master' into autoflake

commit 420c77530975ed6a36ab9f69b1313ba1befe377c
Merge: 4eca6adca dfd56f670
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Wed Jan 26 10:26:48 2022 -0800

    Merge pull request #2387 from janosh/readme-badges

    Fix readme badges

commit 4eca6adca23cc6f68140aea3b735b6be17ac9a73
Merge: 6c31f7e38 ff60e222a
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Wed Jan 26 10:26:10 2022 -0800

    Merge pull request #2389 from janosh/pdentry-repr

    override PDEntry.__repr__ to include name attr if not fallback value

commit ff60e222aa9df1d2a8dc6e6f740495306bbfc815
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Wed Jan 26 18:14:04 2022 +0000

    override PDEntry.__repr__ to include name attr if not fallback value

commit b706b6560ea94f1444bb48d0cdb960b255ec850d
Author: Andrew <asrosen93@gmail.com>
Date:   Wed Jan 26 10:00:08 2022 -0800

    Fix as_dict() test assertions

commit 36d62f7d0e1598feaf833746a8b536504e1a7813
Author: Andrew <asrosen93@gmail.com>
Date:   Wed Jan 26 09:51:28 2022 -0800

    Add tests for default charge/spin mult

commit b872a046fa641a4633672e1fd39a542b033e14c8
Author: Andrew <asrosen93@gmail.com>
Date:   Wed Jan 26 08:38:20 2022 -0800

    Store the actual charge and spin_mult in as_dict()

commit dfd56f6706c44ef35716280786fe796b6fcbd025
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Wed Jan 26 14:40:26 2022 +0000

    uniform shield.io readme badges brought onto 1 line, fix GH CI badge, add PyPI download badge

commit c3592de6d003fd0439af90d3ddf19bd5c0b81b4c
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Wed Jan 26 10:41:26 2022 +0000

    fix self.assertEqual(str(self.cellin), ans)
    in FiestaInputTest.test_str_and_from_string()

commit 2c542054e1fb21b7a04379e0bbf5a7c3024f9f20
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Wed Jan 26 10:24:52 2022 +0000

    remove annoying pylint commit hook, keeps complaining about missing types for standard lib modules like math

    pymatgen/analysis/phase_diagram.py:2929:48: I1101: Module 'math' has no 'sqrt' member, but source is unavailable. Consider adding this module to extension-pkg-allow-list if you want to perform analysis based on run-time introspection of living objects. (c-extension-no-member)

commit f7171f4d753a035c432924d7d5ba5eaad0e74d60
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Wed Jan 26 10:23:55 2022 +0000

    typos

commit 644df535de16868762f6d5a117bc095f249ba3ae
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Wed Jan 26 09:07:42 2022 +0000

    fix UnboundLocalError: local variable 'coord' referenced before assignment in pymatgen/util/tests/test_coord.py

commit a3dda95ac600033ee466fd0714429dd777e1a233
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Wed Jan 26 08:58:14 2022 +0000

    revert openbabel try-except imports

commit 5c1458b36ed82b9b8b62c7cd0c9ed96ad13583c7
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Wed Jan 26 08:42:23 2022 +0000

    convert os + warnings + numpy to own imports in test modules instead of from starred imports

commit 797d99e34ecf42390875d5463c9cb71844ad642c
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Wed Jan 26 08:34:17 2022 +0000

    reduce namespace pollution in pymatgen/util/tests/test_coord.py

commit f76bcd336b294afebf3d367cb522ba9a6aec234a
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Wed Jan 26 08:24:41 2022 +0000

    autoflake -ri --remove-all-unused-imports --ignore-init-module-imports pymatgen

commit 41b1009224ca0b96f9046a9883aaa43dba41c8a9
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Wed Jan 26 08:17:50 2022 +0000

    autoflake expand star imports

commit 6f7c428da87193946cd0b04f5052923b8dda0f14
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Wed Jan 26 08:14:34 2022 +0000

    autoflake remove unused imports + useless pass statements

commit 04d7a99182cfea007e048b1e5700208bb4e721c3
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Wed Jan 26 08:07:42 2022 +0000

    fix KpointsTest.test_init() failing due to change in Kpoints.__str__()

commit b4f43512fc7e9b88a8fcfab41dca2085e4b7374d
Author: samblau <samblau1@gmail.com>
Date:   Tue Jan 25 16:26:30 2022 -0800

    Turn non-NBO output tests back on

commit 20537e4819cc1a25329ff38efe18fa96045a5e98
Merge: b22aba284 6c31f7e38
Author: samblau <samblau1@gmail.com>
Date:   Tue Jan 25 16:21:26 2022 -0800

    Merge branch 'master' into qchem

commit a3b9c2b45705bbff4c025503fd55fb8aef3ca496
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Tue Jan 25 20:09:44 2022 +0000

    fix self.assertEqual(gau.to_string(cart_coords=False), gau_str) due to charge_str = f"{self.charge}" in gau.to_string()

commit deb84ec8060926e217a8546d08d4e73ab6323fce
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Tue Jan 25 19:32:04 2022 +0000

    more auto-conversions from flynt ./pymatgen --aggressive (checked these all more carefully)

commit 6c31f7e38268986bd23110c2fbd4f14a09042a2a
Merge: 5a05f662d 8b697ed4f
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Tue Jan 25 11:01:30 2022 -0800

    Merge pull request #2379 from janosh/flynt

    Flynt

commit 8b697ed4fa702bb2b7ddefb4d9fb9a60fa6a3657
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Tue Jan 25 15:28:30 2022 +0000

     fix ValueError: Format specifier missing precision

commit d068c1e39b4168a93de04745ff8af1a5fe4117c0
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Tue Jan 25 15:02:16 2022 +0000

    commit hook auto fixes in files changed by prev commit

commit 265a2a2b828e8f1cd3063df5571d72c200346769
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Tue Jan 25 15:00:32 2022 +0000

    flynt ./pymatgen (automatic f-string conversion)

commit 5a05f662d35ab3c0d93f252f1c73e813e87c75f6
Merge: bc5af845c 5f09cfbe8
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Tue Jan 25 06:56:09 2022 -0800

    Merge branch 'master' of github.com:materialsproject/pymatgen

commit bc5af845cca5953f7d7623a64341c5bb862839ed
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Tue Jan 25 06:54:31 2022 -0800

    Fix.

commit 5f09cfbe8b575090faaf5901ccab37e50fccf677
Merge: 1a46190f4 671fd7f6a
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Tue Jan 25 06:49:36 2022 -0800

    Merge pull request #2356 from arosen93/rosen-bader

    Minor cleanup of bader_caller.py + new get_partial_charge() convenience function

commit 1a46190f48020669bf34266c81eebf87b89373e1
Merge: cf0f4a327 776dabac8
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Tue Jan 25 06:47:47 2022 -0800

    Merge pull request #2362 from janosh/qa

    QA

commit cf0f4a327329ff31a0af2a5f5a29cbb7ca3ce874
Merge: d8810634d 31f9f33cd
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Tue Jan 25 06:47:27 2022 -0800

    Merge pull request #2371 from arosen93/rosen-ase-props

    Pass oxidation states between Pymatgen structure/molecule and ASE Atoms

commit d8810634ddebac6171b8833aadc87ca0e0dac461
Merge: 41e171b5a c5b8d495e
Author: Matthew Horton <mkhorton@users.noreply.github.com>
Date:   Mon Jan 24 17:28:34 2022 -0800

    Merge pull request #2369 from arosen93/rosen-energy

    Return the correct Vasprun().final_energy for VASP 6+ and change the default Outcar().final_energy to be energy(sigma->0)

commit c5b8d495e400e49a66aad90ddbb2ca31c91ee8f9
Author: Andrew <asrosen93@gmail.com>
Date:   Mon Jan 24 16:30:40 2022 -0800

    Do 1e-7 check in final_energy

commit ee423599fe370547250cc281d7c7935afc67cbf9
Author: Andrew <asrosen93@gmail.com>
Date:   Mon Jan 24 16:25:23 2022 -0800

    Update vasprun.final_energy check to be version-independent

commit 41e171b5aeae63bf73c130f7ef451fd77aa46e0f
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Mon Jan 24 06:25:14 2022 -0800

    Update docs

commit d3b37eb5fb04a919a81c45bed780ce4c4d60477a
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Mon Jan 24 06:23:34 2022 -0800

    Minor update.

commit 8808f7198a49b8358267fc36a1ba7a09cc8484ac
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Mon Jan 24 06:22:28 2022 -0800

    Update changelog.

commit 5b8f704904fff3097ff45c1d182582b553bde686
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Mon Jan 24 06:20:01 2022 -0800

    fix deprecated default flow style in YAML.
    Fixes #2373.

commit 31f9f33cd3ea19aec9196163b285f8fbe512aace
Author: Andrew <asrosen93@gmail.com>
Date:   Sun Jan 23 21:08:34 2022 -0800

    Pass oxi states between ASE and pymatgen

    Now oxidation states are passed between ASE and Pymatgen structure objects. Several new tests have been added.

commit afe802b10f7907b22141e2154f323900a412e351
Merge: 3cf1b4206 4813709cb
Author: Andrew S. Rosen <asrosen93@gmail.com>
Date:   Sat Jan 22 22:42:36 2022 -0800

    Merge branch 'materialsproject:master' into rosen-energy

commit 3cf1b42067209f8743f7512cc13976948b9cc32d
Author: Andrew <asrosen93@gmail.com>
Date:   Sat Jan 22 21:39:36 2022 -0800

    Fix Outcar test

commit 844f185b41b9c9af9e1e6bd26515f7a74eb0ce32
Author: Andrew <asrosen93@gmail.com>
Date:   Sat Jan 22 21:39:16 2022 -0800

    Update Outcar() docs

commit a9eff3f577fa7b2251f57173b4c054fc4a110e7a
Author: Andrew <asrosen93@gmail.com>
Date:   Sat Jan 22 21:22:13 2022 -0800

    Fix vasprun energy parsing for vdW

commit e10abaaef87379349f0d064f1222c84a32a88681
Author: Andrew <asrosen93@gmail.com>
Date:   Sat Jan 22 20:14:20 2022 -0800

    Add tests to address energy parsing issue with Vasprun

commit 18ee0cc8f8fec8d4a1664ec782e2368ed6028d78
Author: Andrew <asrosen93@gmail.com>
Date:   Sat Jan 22 19:16:06 2022 -0800

    Fix dielect OUTCAR test

commit 4813709cbccd35543e192cef6b7cf78153624cd6
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Sat Jan 22 18:22:37 2022 -0800

    Fix memory error

commit fe4af2dd3523b1b686c23176fb549a98403f25e1
Author: Andrew <asrosen93@gmail.com>
Date:   Sat Jan 22 18:09:47 2022 -0800

    Return the correct e_0_energy with Vasprun and Outcar .final_energy

commit 7ac21b710e68e723d8fb556410787965740cac04
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Sat Jan 22 17:01:37 2022 -0800

    Comment out bad test.

commit c07cd2bebfec5f68a3fd29d5c01c4a5f0d1501a7
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Sat Jan 22 16:39:59 2022 -0800

    Fix wannier.

commit 362e26fd69a121f5855ffc413de361b0c8cd1a9e
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Sat Jan 22 16:04:30 2022 -0800

    Fix numpy int deprecations. Fixes #2366.

commit ae3f1b77d75b397735ee7cf16fcd77d8f487d85e
Merge: 729a26f2f 6753761b1
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Fri Jan 21 12:14:48 2022 -0800

    Merge branch 'master' of github.com:materialsproject/pymatgen

commit 729a26f2f0d9b6ca083dcaffb86402b5e0be96ee
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Fri Jan 21 12:14:35 2022 -0800

    Fix release workflow.

commit 776dabac89585ad7b9a5274f53515aa09ecf39e3
Merge: 05fcc2797 6753761b1
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Fri Jan 21 06:17:56 2022 +0000

    Merge branch 'master' into qa

commit 593a18872ba19735f9d8296998a0f45aa179b2c9
Author: Andrew <asrosen93@gmail.com>
Date:   Thu Jan 20 20:18:03 2022 -0800

    Fix max_row kwarg in periodic table heatmap plotter

commit c6d38b11dadf4ed5ada3f98cb7bf58a34960eb62
Merge: 43d9fc768 6753761b1
Author: Andrew S. Rosen <asrosen93@gmail.com>
Date:   Thu Jan 20 19:51:40 2022 -0800

    Merge branch 'materialsproject:master' into rosen-ddec

commit b06efb1205af52e2eed8547ef68a672ef1ca3b05
Author: Andrew <asrosen93@gmail.com>
Date:   Thu Jan 20 19:36:14 2022 -0800

    Fix from_row_and_group test

commit 55bf07a9c24e363f7f8d8fb396575d49879cf3fd
Author: Andrew <asrosen93@gmail.com>
Date:   Thu Jan 20 19:16:59 2022 -0800

    Fix from_row_and_group test

commit a5082776043f530c5f67303b53a0e9614306ae6a
Author: Andrew <asrosen93@gmail.com>
Date:   Thu Jan 20 19:09:25 2022 -0800

    Fix row and group test

commit 235e1b5d39c7c33454393fe7383ad17c2d4ce422
Author: Andrew <asrosen93@gmail.com>
Date:   Thu Jan 20 18:58:08 2022 -0800

    Add new for test from_row_and_group

commit 5353523c642b473e306927fd195052a58f9998c9
Author: Andrew <asrosen93@gmail.com>
Date:   Thu Jan 20 18:51:47 2022 -0800

    Add test cases for new group/row convention

commit 5c29d1d4b917865055eb83894eab6b4f5854ae6f
Author: Andrew <asrosen93@gmail.com>
Date:   Thu Jan 20 18:00:49 2022 -0800

    Fix ptable plotter

commit 0d8038a487bab90f26a0ef2577bf74823f53c35f
Author: Andrew <asrosen93@gmail.com>
Date:   Thu Jan 20 17:38:07 2022 -0800

    Fiz el.z typo in ptable plotter

commit 19247c6060830b561f3c2e70ecb7030b7895e7ad
Author: Andrew <asrosen93@gmail.com>
Date:   Thu Jan 20 17:35:02 2022 -0800

    Fix ptable plotter for new lanthanoid/actinoid group #

commit 43d9fc768396929310db3dde0745a2b613145f30
Author: Andrew <asrosen93@gmail.com>
Date:   Thu Jan 20 17:15:12 2022 -0800

    Use fstring in ChargemolAnalysis

commit 3979c7410573f4e6e7bbe0176784691292ba5417
Author: Andrew <asrosen93@gmail.com>
Date:   Thu Jan 20 16:51:23 2022 -0800

    Add code comment for ChargemolAnalysis.summary

commit 46415dab1cbf8c830434e21bf79e85da06a377ce
Author: Andrew <asrosen93@gmail.com>
Date:   Thu Jan 20 16:47:35 2022 -0800

    Add test for get_charge() in ChargemolAnalysis

commit 4ce2389ea83d1cbc831970fd49ba37ad8317acdb
Author: Andrew <asrosen93@gmail.com>
Date:   Thu Jan 20 16:40:33 2022 -0800

    Add tests for Chargemol

commit 6753761b1f332b70507b8e019114ac65c45b5c75
Merge: 9cc63cac1 5792dcb1a
Author: Matthew Horton <mkhorton@users.noreply.github.com>
Date:   Thu Jan 20 14:08:06 2022 -0800

    Merge pull request #2358 from arosen93/rosen-mags

    Don't perform dict type-check on the MAGMOM flag in io.vasp.sets (fixes downstream Atomate issue)

commit 5792dcb1a66814c4390ad64b73dd2f899fa32cdd
Author: Andrew <asrosen93@gmail.com>
Date:   Thu Jan 20 13:10:07 2022 -0800

    Fix MPStaticSet test

commit 9cc63cac182dcf219c2a1791d7e36d3fe3c2c3b5
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Thu Jan 20 12:46:24 2022 -0800

    Update docs

commit 6ba78931fef96af12779a1221727ba0353a1ceb6
Author: Shyue Ping Ong <shyuep@gmail.com>
Date:   Thu Jan 20 12:45:13 2022 -0800

    Update changelog.

commit 91c7fb0642f8fc37a76bab491da2e3631aee1f83
Author: Andrew <asrosen93@gmail.com>
Date:   Thu Jan 20 12:36:39 2022 -0800

    Remove typecheck from magmom test

    Remove the typecheck for MAGMOM being a dict

commit d5370df167e92aa4293a1bd15cc49c327be46cbd
Merge: fd553a8e8 e181a7fb8
Author: Shyue Ping Ong <shyuep@users.noreply.github.com>
Date:   Thu Jan 20 12:19:57 2022 -0800

    Merge pull request #2365 from janosh/fix_get_potcar_symbols

    Fix Lobsterin()._get_potcar_symbols()

commit 200bb9c882adac3786b1c126d9b7e74d17b5957f
Author: Andrew <asrosen93@gmail.com>
Date:   Thu Jan 20 12:14:44 2022 -0800

    Lint fix

commit 2cfdc3cdc0fde394b86a670ca0714a3c49e88e9c
Merge: 42bcf08f9 7c550b987
Author: Andrew <asrosen93@gmail.com>
Date:   Thu Jan 20 11:46:50 2022 -0800

    Merge remote-tracking branch 'origin/rosen-mags' into rosen-mags

commit 42bcf08f92bd7267824edd7d1dcfe79d23ca3769
Author: Andrew <asrosen93@gmail.com>
Date:   Thu Jan 20 11:46:45 2022 -0800

    Remove TypeError when MAGMOM is not a dict

commit e181a7fb800d7dff1a1074bc0be25f10e8558034
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Thu Jan 20 19:18:06 2022 +0000

    ensure POTCAR data has utf-8 encoding

commit 6c57902c8fa7834c30c40e6ccb4ac6066edf6dfb
Author: Andrew <asrosen93@gmail.com>
Date:   Thu Jan 20 11:02:21 2022 -0800

    mypy fix

commit 05fcc2797fce6f5b01c0c3c4c993575f49f984c7
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Thu Jan 20 15:15:49 2022 +0000

    update hash for vdW_parameters.yaml in SetChangeCheckTest

commit 8b4fb15b32e1694438e39b636efdb46e009f1442
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Thu Jan 20 11:12:42 2022 +0000

    add autoflake cmmit hook

commit d7b4fba0cb04a5b80829613674f936b1418f9b54
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Thu Jan 20 11:06:39 2022 +0000

    add pyupgrade commit hook

commit 862bf7b4c36da03cd4fda3beb5b0394e66ff7f34
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Thu Jan 20 11:03:53 2022 +0000

    pyupgrade --py38-plus **/*.py

commit 586bea41032781c8ccac1a6fdfc6ad3d96baa555
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Thu Jan 20 10:53:06 2022 +0000

    apply end-of-file-fixer + trailing-whitespace

commit 9f13e8c2ea91baf692329b41487e7cf771437df5
Author: Janosh Riebesell <janosh.riebesell@gmail.com>
Date:   Thu Jan 20 10:52:08 2022 +0000

    update pre-commit config, exclude (docs|test_files), use standalone flake8 hook

commit c8893438b69642122950547b7ff17a844c258c33
Author: Andrew <asrosen93@gmail.com>
Date:   Thu Jan 20 02:17:35 2022 -0800

    mypy fix

commit ac26d556340a7fcdfe58ee53f02b432407418565
Author: Andrew <asrosen93@gmail.com>
Date:   Thu Jan 20 02:02:38 2022 -0800

    Introduce test suite for ChargemolAnalysis

commit 671fd7f6a15261715c594694e4e3aad5e4b47d6f
Author: Andrew <asrosen93@gmail.com>
Date:   Thu Jan 20 01:18:04 2022 -0800

    Add two more bader tests

commit b1dc48d41bec78cc8dd79b0a3dbfe717aadf2d42
Author: Andrew <asrosen93@gmail.com>
Date:   Thu Jan 20 01:14:41 2022 -0800

    Finalize chargemol_caller.py

    Creates chargemol_caller.py for DDEC/CM5 analysis

commit 646d13853acb5ae247954e82f5a77829d568f842
Author: Andrew <asrosen93@gmail.com>
Date:   Thu Jan 20 01:12:48 2022 -0800

    finalize bader_caller cleanup

    Minor code clarifications for bader_caller. Also adds new get_partial_chage() convenience function

commit d33eb3138dfc0017b4de0ac40b9c79fecfbe6865
Merge: 32bda0f32 7b2757a80
Author: Andrew <asrosen93@gmail.com>
Date:   Wed Jan 19 15:40:11 2022 -0800

    Merge remote-tracking branch 'origin/rosen-ddec' into rosen-ddec

commit 32bda0f3207d7878bfcc5e6c38290a0ac5b87ce2
Author: Andrew <asrosen93@gmail.com>
Date:   Wed Jan 19 15:40:…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants