Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2022.11.7 #2726

Merged
merged 3 commits into from
Nov 8, 2022
Merged

Release v2022.11.7 #2726

merged 3 commits into from
Nov 8, 2022

Conversation

janosh
Copy link
Member

@janosh janosh commented Nov 8, 2022

As requested by @utf in #2720, here's a new release to unblock downstream repos like atomate, atomate2, amset.

@shyuep invoke release is giving me a bunch of sphinx errors. Can we release without updating docs since last doc update is just 6 days old?

@shyuep
Copy link
Member

shyuep commented Nov 8, 2022

If you install sphinx, it shouldn't be giving errors.

@coveralls
Copy link

coveralls commented Nov 8, 2022

Coverage Status

Coverage remained the same at 0.0% when pulling af5fd94 on release into ffbebce on master.

@janosh
Copy link
Member Author

janosh commented Nov 8, 2022

Sorry, in a rush earlier. I did install sphinx. Then got errors about missing sphinx_rtd_theme. Installed that. Then got errors about missing sphinx extensions. Installed those too. Then got errors about missing GITHUB_RELEASES_TOKEN, and so on.

@janosh
Copy link
Member Author

janosh commented Nov 8, 2022

@shyuep Does the large line deletion count mean sth went wrong? After my last comment, I reverted the auto-pushed commit af5fd94 and got invoke release to run error-free locally but got the same results. The 22k deleted lines look suspicious.

@shyuep
Copy link
Member

shyuep commented Nov 8, 2022

If the deleted lines are html files, then it is ok.

@janosh
Copy link
Member Author

janosh commented Nov 8, 2022

Yes, no Python files changed except setup.py and pymatgen/__init__.py.

@janosh janosh merged commit c7fe7f5 into master Nov 8, 2022
@janosh janosh deleted the release branch November 8, 2022 04:23
@utf
Copy link
Member

utf commented Nov 8, 2022

This did not get released to pypi only GitHub. E.g., https://pypi.org/project/pymatgen/ the latest version is still 2022.11.1

@janosh
Copy link
Member Author

janosh commented Nov 8, 2022

@utf Yeah, I saw the release workflow failed but got drawn away by another problem last night so didn't have time to debug this yet. Let me take a look now.

@janosh
Copy link
Member Author

janosh commented Nov 8, 2022

So the problem is I didn't notice setup.py imports numpy when I did #2707. Now that the CI scripts have single-line installs for (almost) all deps

pip install -e '.[dev,optional]'

numpy won't be installed until after python setup.py has run which already tries to import numpy. I think the correct way to fix this is to use setuptools's fetch_build_eggs which "resolves pre-setup requirements".

@janosh janosh mentioned this pull request Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants