Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use cibuildwheel to build linux wheels #2800

Merged
merged 12 commits into from Feb 25, 2023
Merged

use cibuildwheel to build linux wheels #2800

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
94ab971
build linux wheels
njzjz Jan 11, 2023
46f6169
fix undefined symbols from libgfortran.so.3
njzjz Jan 13, 2023
1954fdc
only build 64-bit
njzjz Jan 13, 2023
1d01c44
skip musllinux
njzjz Jan 13, 2023
ffd8564
Merge branch 'master' into cibuildwheel
njzjz Feb 22, 2023
3cbe989
set LD_LIBRARY_PATH for macos
njzjz Feb 22, 2023
c22457c
typo
njzjz Feb 22, 2023
22e734d
typo
njzjz Feb 22, 2023
b3f5d43
do not repair or macos
njzjz Feb 22, 2023
ab1a1ea
Merge branch 'master' into cibuildwheel
njzjz Feb 24, 2023
51aa037
resolve comments
njzjz Feb 25, 2023
86e1877
fix typo
njzjz Feb 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
58 changes: 40 additions & 18 deletions .github/workflows/test.yml
View file
Open in desktop
Expand Up @@ -124,28 +124,50 @@ jobs:
continue-on-error: true
uses: AndreMiras/coveralls-python-action@v20201129

release:
build_sdist:
needs: pytest
name: Build source distribution
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
name: Install Python
with:
python-version: '3.10'
- run: python -m pip install build
- name: Build sdist
run: python -m build --sdist
- uses: actions/upload-artifact@v3
with:
path: dist/*.tar.gz

build_wheels:
needs: pytest
if: github.event_name == 'release' || (github.event_name == 'workflow_dispatch' && inputs.task == 'release')
strategy:
matrix:
os: [macos-latest, windows-latest]
python-version: ['3.8', '3.9', '3.10', '3.11']
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: ['38', '39', '310', '311']
runs-on: ${{ matrix.os }}

steps:
- uses: actions/checkout@v3
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
cache: pip
cache-dependency-path: setup.py
- name: Release
- name: Build wheels
uses: pypa/cibuildwheel@v2.11.4
env:
TWINE_USERNAME: ${{ secrets.TWINE_USERNAME }}
TWINE_PASSWORD: ${{ secrets.TWINE_PASSWORD }}
run: |
python -m pip install --upgrade pip twine build
python -m build
python -m twine upload --skip-existing dist/*.whl dist/*.tar.gz
CIBW_BUILD: cp${{ matrix.python-version }}-*
- uses: actions/upload-artifact@v3
with:
path: ./wheelhouse/*.whl

release:
needs: [build_wheels, build_sdist]
if: github.event_name == 'release' || (github.event_name == 'workflow_dispatch' && inputs.task == 'release')
runs-on: ubuntu-latest
steps:
- uses: actions/download-artifact@v3
with:
name: artifact
path: dist
- uses: pypa/gh-action-pypi-publish@master
with:
user: ${{ secrets.TWINE_USERNAME }}
password: ${{ secrets.TWINE_PASSWORD }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this offer advantages over running twine upload manually? I'm wondering if it's worth relying on an external action for sth this simple since it might lock us into waiting for fixes if the action ever breaks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, twine upload should also work.

8 changes: 8 additions & 0 deletions pyproject.toml
View file
Open in desktop
Expand Up @@ -10,6 +10,14 @@ build-backend = "setuptools.build_meta"
[tool.black]
line-length = 120

[tool.cibuildwheel.linux]
archs = ["auto64"]
skip = ["*musllinux*"]
before-all = "ln -s /usr/lib64/libgfortran.so.5 /usr/lib64/libgfortran.so.3"

[tool.cibuildwheel.macos]
repair-wheel-command = ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this section? What's the default for repair-wheel-command?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default is below

[tool.cibuildwheel.macos]
repair-wheel-command = "delocate-wheel --require-archs {delocate_archs} -w {dest_dir} -v {wheel}"

However, in cmd_line directory, some binary files link to external dependencies outside the repository, and make the repair command fail.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I change to

repair-wheel-command = "delocate-wheel --require-archs {delocate_archs} -w {dest_dir} -v {wheel} --ignore-missing-dependencies"

--ignore-missing-dependencies should work for this situation.


[tool.ruff]
target-version = "py38"
line-length = 120
Expand Down