Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unignore flake8 B028 and fix occurrences #2807

Merged
merged 5 commits into from
Jan 18, 2023
Merged

Unignore flake8 B028 and fix occurrences #2807

merged 5 commits into from
Jan 18, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Jan 18, 2023

@janosh
un-ignore flake8 B028 error and fix occurrences
7a0abfd
@janosh
fix pymatgen/analysis/chemenv/coordination_environments/tests/test_co…
371913c 
…ordination_geometries.py:299

>       assert str(exc_info.value) == 'No coordination geometry found with name "Octahedran"'
E       assert "No coordinat... 'Octahedran'" == 'No coordinat... "Octahedran"'
E         - No coordination geometry found with name "Octahedran"
E         ?                                          ^          ^
E         + No coordination geometry found with name 'Octahedran'
E         ?                                          ^          ^
@coveralls
Copy link

coveralls commented Jan 18, 2023 •
edited
Loading

Coverage Status

Coverage: 78.806%. Remained the same when pulling 790dea5 on flake8-B028 into e1c075c on master.

@janosh janosh enabled auto-merge (squash) January 18, 2023 16:10
@janosh
fix pymatgen/analysis/chemenv/coordination_environments/tests/test_we…
de2831b 
…ights.py:136

with pytest.raises(
            ValueError, match='Average type is "arithmetix" ' 'while it should be "geometric" or "arithmetic"'
        ):
>           NormalizedAngleDistanceNbSetWeight(average_type="arithmetix", aa=1, bb=1)
@janosh
revert {!r} in nwchem bset_spec.append
790dea5
@janosh janosh merged commit 582cb83 into master Jan 18, 2023
@janosh janosh deleted the flake8-B028 branch January 18, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@janosh @coveralls