Avoid adjusting input entries in mixing schemes. #2830
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here to submit changes to avoid change input entries in place.
In both of GGA/GGA+U and GGA/GGA+U/R2SCAN mixing processes, the methods below not only return adjusted entries, but also change input entries in place. Is it necessary? I think this may cause bugs in programming.
MaterialsProjectDFTMixingScheme.process_entries()
entries.compatibility.process_entries()
Thanks!