Conversation
remove numpy.typing.ArrayLike re-export from pymatgen/util/typing.py
janosh
enabled auto-merge (squash)
May 16, 2023 15:10
Member
Author
|
Ci failure is due to flaky test: @unittest.skipIf(
not SETTINGS.get("PMG_MAPI_KEY") or website_down,
"PMG_MAPI_KEY environment variable not set or MP is down.",
)
def test_get_snls_mp(self):
with OptimadeRester("mp") as optimade:
structs = optimade.get_snls(elements=["Ga", "N"], nelements=2)
with OptimadeRester("mp") as optimade:
response_field_structs_single = optimade.get_snls(
elements=["Ga", "N"], nelements=2, additional_response_fields="nsites"
)
response_field_structs_set = optimade.get_snls(
elements=["Ga", "N"], nelements=2, additional_response_fields={"nsites", "nelements"}
)
if ("mp" in response_field_structs_single) and ("mp" in response_field_structs_set):
> assert len(structs["mp"]) == len(response_field_structs_single["mp"])
E KeyError: 'mp'
pymatgen/ext/tests/test_optimade.py:55: KeyError |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4 main motivations for this change:
pymatgen.analysis.defectsif they were previously in a test's import stack but only used for type hintsTYPE_CHECKING=Falseat run time means some modules won't have to be imported. somewhat negated by the annoyingly long import time of the std libtypingmodule itself but that has been steadily coming down with newer Python versions.