Fix ValueError when structure.selective_dynamics has type np.array
#3012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t is ambiguous. Use a.any() or a.all() when structure.selective_dynamics has type np.array
…cs in only some dimensions. Remove the selective_dynamics=[False, False, False] ignore mypy assignment error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3011.
71e888d refactor LammpsData.get_string()
a1d3509 refactor ase import, AseAtomsAdaptor.get_atoms() check is_struct
a21543c fix ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all() when structure.selective_dynamics has type np.array
bf56232 add cases testing selective_dynamics as list and array to test_get_structure_dyn()