Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak variable names #3019

Merged
merged 7 commits into from May 29, 2023
Merged

Tweak variable names #3019

merged 7 commits into from May 29, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented May 29, 2023

Also use modern f"{float:+}" for explicit + signs.

@janosh janosh added the housekeeping Linting fixes, cleaning up and refactoring code label May 29, 2023
E       TypeError: sequence item 3: expected str instance, int found
>               label += f"{ads:+}"
E               ValueError: Sign not allowed in string format specifier
@janosh janosh enabled auto-merge (squash) May 29, 2023 18:38
>       assert all_latex == correct_latex
E       AssertionError: assert ['Li$^{+1}$',...$^{-4}$', ...] == ['Li$^{+1}$',...$^{-4}$', ...]
@janosh janosh merged commit 9e400f2 into master May 29, 2023
26 checks passed
@janosh janosh deleted the simplify-signed-float-fmt branch May 29, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Linting fixes, cleaning up and refactoring code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant