Skip to content

Unignore ruff PD011 - #3020

Merged
janosh merged 5 commits into
masterfrom
unignore-ruff-PD011
May 30, 2023
Merged

Unignore ruff PD011#3020
janosh merged 5 commits into
masterfrom
unignore-ruff-PD011

Conversation

@janosh

@janosh janosh commented May 30, 2023

Copy link
Copy Markdown
Member

c535f49 ruff unignore PD011 (pandas-use-of-dot-values)
7d3eba4 drop .values where not needed, else replace with .to_numpy(), noqa false positives

pandas.DataFrame().values is deprecated and slated for removal in a future pandas version.

@janosh
janosh enabled auto-merge (squash) May 30, 2023 01:01
@janosh janosh added linting Linting and quality assurance housekeeping Moving around or cleaning up old code/files labels May 30, 2023
janosh added 3 commits May 29, 2023 18:11
       assert ss["force_eval"]["dft"]["poisson"].get("periodic").to_numpy()[0].upper() == "NONE"
E       AttributeError: 'Keyword' object has no attribute 'to_numpy'
@janosh
janosh merged commit 3c91e69 into master May 30, 2023
@janosh
janosh deleted the unignore-ruff-PD011 branch May 30, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

housekeeping Moving around or cleaning up old code/files linting Linting and quality assurance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant