Breaking: Rename [SomeCode]ParserError to [SomeCode]ParseError and inherit from SyntaxError
#3140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make all ParseError classes inherit from pymatgen.io.core.ParseError which is a SyntaxError subclass. allows for adding line numbers and filenames to errors
class SyntaxError(Exception):
msg: str
lineno: int | None
offset: int | None
text: str | None
filename: str | None
if sys.version_info >= (3, 10):
end_lineno: int | None
end_offset: int | None
janosh
added
io
janosh
changed the title
[SomeCode]ParserError to [SomeTool]ParseError and inherit from SyntaxError[SomeCode]ParserError to [SomeCode]ParseError and inherit from SyntaxError
janosh
added a commit
that referenced
this pull request
Jul 11, 2023
make all ParseError classes inherit from pymatgen.io.core.ParseError which is a SyntaxError subclass. allows for adding line numbers and filenames to errors
class SyntaxError(Exception):
msg: str
lineno: int | None
offset: int | None
text: str | None
filename: str | None
if sys.version_info >= (3, 10):
end_lineno: int | None
end_offset: int | None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By making all
ParseErrorclasses inherit from the newpymatgen.io.core.ParseError(used to be genericException) which subclassesSyntaxError,ParseErrorscan now add line numbers and filenames to errors: