Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CifParser.get_structures(on_error='warn') #3175

Merged
merged 3 commits into from
Jul 22, 2023
Merged

Add CifParser.get_structures(on_error='warn') #3175

merged 3 commits into from
Jul 22, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Jul 22, 2023

Closes #3174.

Doesn't actually change the default behavior of CifParser.get_structures(). That seemed too breaking. Instead adds a new kwarg

on_error: Literal["ignore", "warn", "raise"] = "warn"

which is a step towards better error messages on parse errors when set to "error".

@janosh janosh added io Input/output functionality ux User experience labels Jul 22, 2023
@janosh janosh enabled auto-merge (squash) July 22, 2023 03:05
@janosh janosh merged commit f9f2508 into master Jul 22, 2023
26 of 27 checks passed
@janosh janosh deleted the fix-gh-3174 branch July 22, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
io Input/output functionality ux User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.cif file from Cambridge Structural Database returns "ValueError: Invalid cif file with no structures!"
1 participant