Improve Structure tests#3197
Merged
Merged
Conversation
instead use public setter (Structure|Molecule).sites
…rn supercell structure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most notable user-facing change: add
in_place: bool = Truekeyword toStructure.make_supercell()and return the supercell.a70f4c4 add
Structure/Molecule.sitessetter, move@propertyto SiteCollection7f510ca don't use implementation detail
(Structure|Molecule)._sitesc5052a2 rename
StructureTest.structureattr tostruct28a895f add
IStructureTest.test_sites_setter185d2cb fix mypy
94f4413 test
translate/rotate_sitesIndexErrorif "list index out of range"2ffd3bb tweak doc strings
f482ba0 test inverse
translate_sitesoperations leave structure unchanged7197592
Structure.make_supercell()addin_place: bool = Truekeyword and return supercell structure638c095 test
make_supercellin_place=TrueandFalse