Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isomorphic for molecular graphs #3221

Merged
merged 6 commits into from Aug 5, 2023

Conversation

rohithsrinivaas
Copy link
Contributor

Closes #3164

@janosh janosh enabled auto-merge (squash) August 5, 2023 00:06
@janosh janosh added fix Bug fix PRs analysis Concerning pymatgen.analysis molecules Molecule stuff labels Aug 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2023

Codecov Report

Patch coverage: 76.47% and project coverage change: -0.56% ⚠️

Comparison is base (5865c95) 73.40% compared to head (5c648e5) 72.85%.

❗ Current head 5c648e5 differs from pull request most recent head 23f4e5c. Consider uploading reports for the commit 23f4e5c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3221      +/-   ##
==========================================
- Coverage   73.40%   72.85%   -0.56%     
==========================================
  Files         238      238              
  Lines       70251    70252       +1     
  Branches    16332    16332              
==========================================
- Hits        51570    51183     -387     
- Misses      15543    15965     +422     
+ Partials     3138     3104      -34     
Files Changed Coverage Δ
pymatgen/analysis/graphs.py 74.77% <76.47%> (+0.02%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janosh janosh merged commit f32102c into materialsproject:master Aug 5, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis Concerning pymatgen.analysis fix Bug fix PRs molecules Molecule stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Isomorphic Edge Comparison Issue
3 participants