Fix ruff PYI041 and ignore PYI024
#3232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janosh
added
housekeeping
> analysis = BaderAnalysis(chgcar_filename=f"{TEST_FILES_DIR}/CHGCAR.Fe3O4")
tests/command_line/test_bader_caller.py:64
…such file or directory: ''
/home/runner/work/pymatgen/pymatgen/tests/command_line/test_bader_caller.py:81:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/home/runner/work/pymatgen/pymatgen/pymatgen/command_line/bader_caller.py:426: in from_path
return cls(
/home/runner/work/pymatgen/pymatgen/pymatgen/command_line/bader_caller.py:111: in __init__
self.potcar = Potcar.from_file(potcar_filename) if potcar_filename is not None else None
/home/runner/work/pymatgen/pymatgen/pymatgen/io/vasp/inputs.py:2256: in from_file
with zopen(filename, "rt") as f:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d317631 fix ruff PYI041 (redundant-numeric-union)
2faafa2 ruff ignore PYI024
4b756d0 remove over-engineered _attr_desc = namedtuple
ca70565 fix CI AttributeError: 'NoneType' object has no attribute 'split'