Skip to content

Fix ruff PYI041 and ignore PYI024#3232

Merged
janosh merged 7 commits into
masterfrom
fix-ruff
Aug 9, 2023
Merged

Fix ruff PYI041 and ignore PYI024#3232
janosh merged 7 commits into
masterfrom
fix-ruff

Conversation

@janosh
Copy link
Copy Markdown
Member

@janosh janosh commented Aug 9, 2023

d317631 fix ruff PYI041 (redundant-numeric-union)
2faafa2 ruff ignore PYI024
4b756d0 remove over-engineered _attr_desc = namedtuple
ca70565 fix CI AttributeError: 'NoneType' object has no attribute 'split'

@janosh janosh added housekeeping Moving around or cleaning up old code/files ci Continuous integration labels Aug 9, 2023
>       analysis = BaderAnalysis(chgcar_filename=f"{TEST_FILES_DIR}/CHGCAR.Fe3O4")

tests/command_line/test_bader_caller.py:64
@janosh janosh enabled auto-merge (squash) August 9, 2023 02:00
janosh added 3 commits August 9, 2023 08:35
…such file or directory: ''

/home/runner/work/pymatgen/pymatgen/tests/command_line/test_bader_caller.py:81:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/home/runner/work/pymatgen/pymatgen/pymatgen/command_line/bader_caller.py:426: in from_path
    return cls(
/home/runner/work/pymatgen/pymatgen/pymatgen/command_line/bader_caller.py:111: in __init__
    self.potcar = Potcar.from_file(potcar_filename) if potcar_filename is not None else None
/home/runner/work/pymatgen/pymatgen/pymatgen/io/vasp/inputs.py:2256: in from_file
    with zopen(filename, "rt") as f:
@janosh janosh disabled auto-merge August 9, 2023 16:41
@janosh janosh merged commit 313eae0 into master Aug 9, 2023
@janosh janosh deleted the fix-ruff branch August 9, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous integration housekeeping Moving around or cleaning up old code/files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant