Breaking: remove deprecated keyword properties from Species #3243
Merged
Breaking: remove deprecated keyword properties from Species #3243
properties from Species #3243Conversation
janosh
added
breaking
janosh
changed the title
Species keyword propertiesproperties from Species
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4b9033a remove deprecated kwarg
propertiesfromSpecies+DummySpecies38b30a3 snake_case vars
48b8f16 fix
Structure.add_spin_by_elementandadd_spin_by_site4ffc371 fix tests that used
Species(properties={...})33283b0 update
Substitutor.pred_from_structuresdoc str7ba3245 fix
MagOrderingTransformation._add_dummy_species