Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TestMPStaticSet using MPRelaxSet in test_user_incar_kspacing and test_kspacing_override #3268

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Fix TestMPStaticSet using MPRelaxSet in test_user_incar_kspacing and test_kspacing_override #3268

merged 3 commits into from
Aug 23, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Aug 23, 2023

d568f04 fix TestMPStaticSet running with MPRelaxSet instead of MPStaticSet in test_user_incar_kspacing and test_kspacing_override
86f03de add self.set attribute to InputSetTests to make it harder to use the wrong InputSet in a test

Again, thanks for reporting @SophiaRuan.

@janosh janosh added tests Issues with or changes to the pymatgen test suite io Input/output functionality fix Bug fix PRs vasp Vienna Ab initio Simulation Package labels Aug 23, 2023
@janosh
fix outdated ValueError msg in PotcarSingle.from_symbol_and_functional
4b32927 
or you may need to set PMG_DEFAULT_FUNCTIONAL to PBE_52 or PBE_54 if you are using newer psps from VASP.
@janosh janosh merged commit c4296e4 into master Aug 23, 2023
1 of 2 checks passed
@janosh janosh deleted the fix-TestMPStaticSet branch August 23, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix Bug fix PRs io Input/output functionality tests Issues with or changes to the pymatgen test suite vasp Vienna Ab initio Simulation Package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@janosh