Repository navigation
Ion: default hydrates=False in reduced_formula - #3350
Merged
Merged
Conversation
Member
|
@rkingsbury Is this intentionally in draft mode? |
rkingsbury
marked this pull request as ready for review
October 9, 2023 11:01
Contributor
Author
|
@janosh it was intentional, but I think it's good to go. All tests pass, but I wanted to make sure that this didn't mess up anything on the API side. When we re-did the Pourbaix ion data, I used In the API client, the only call is |
janosh
approved these changes
Oct 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Major changes:
hydrates=FalseinIon.get_reduced_formula_and_factor()Ion.get_reduced_formula_and_factor()rather thansuper().get_reduced_formula_and_factor()in `reduced_formulaChecklist
ruff.mypy.