Fix TestMPResterNewBasic + AseAtomsAdaptor test errors and TransformedStructure.from_snl overwriting hist variable
#3362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_computed_file_hash should be md5_header_hash
janosh
added
tests
…ecorator added to AseAtomsAdaptor
structure = aio.AseAtomsAdaptor.get_structure(atoms)
janosh
commented
Sep 30, 2023
| @@ -40,7 +40,6 @@ | |||
|
|
|||
| # NOTE: If making notable changes to this class, please ping @Andrew-S-Rosen on GitHub. | |||
| # There are some subtleties in here, particularly related to spins/charges. | |||
| @requires(ase_loaded, "ASE needs to be installed.") | |||
There was a problem hiding this comment.
@Andrew-S-Rosen @shyuep I had to revert the @requires decorator added to AseAtomsAdaptorin in #3359 because it breaks the staticmethod namespace resolution below Python 3.10.
with pytest.raises(AttributeError, match="summary is not an attribute"): E Failed: DID NOT RAISE <class 'AttributeError'>
janosh
changed the title
TransformedStructure.from_snl overwriting hist variableTestMPResterNewBasic + AseAtomsAdaptor test errors and TransformedStructure.from_snl overwriting hist variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d919b59 fix typos
c1c9a10 fix for loop overwriting hist variable in TransformedStructure.from_snl
596a56e fix TestVasprun.test_update_potcar using wrong PotcarSingle hash: md5_computed_file_hash should be md5_header_hash