Further updating POTCAR validation / identification #3392
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In some releases of VASP POTCARs, there exist multiple POTCARs with the same TITEL. The previous summary statistics used to uniquely ID POTCARs relied on the uniqueness of TITELs. The current implementation allows for multiple POTCARs within a single release to have the same TITEL field, but different data. The summary statistics have also been updated.
For context: those with a PSP license, take a look at the PBE pseudopotentials W_pv and W_pv_new. Both have the same TITEL, thus W_pv_new was likely intended to be an in-place update of W_pv. However both are "valid" POTCARs.
Some other things to note for future POTCAR releases: