Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further updating POTCAR validation / identification #3392

Merged
merged 6 commits into from Oct 10, 2023

Conversation

esoteric-ephemera
Copy link
Contributor

@esoteric-ephemera esoteric-ephemera commented Oct 10, 2023

Summary

In some releases of VASP POTCARs, there exist multiple POTCARs with the same TITEL. The previous summary statistics used to uniquely ID POTCARs relied on the uniqueness of TITELs. The current implementation allows for multiple POTCARs within a single release to have the same TITEL field, but different data. The summary statistics have also been updated.

For context: those with a PSP license, take a look at the PBE pseudopotentials W_pv and W_pv_new. Both have the same TITEL, thus W_pv_new was likely intended to be an in-place update of W_pv. However both are "valid" POTCARs.

Some other things to note for future POTCAR releases:

  • Some POTCARs are misplaced, e.g., the PBE C_d POTCAR is an LDA POTCAR, but officially released in the PBE library. That requires changing how the validator searches for possible matches
  • Some POTCARs were updated in place by VASP without version control, e.g., Eu and other lanthanides in the PBE library. Thus multiple Eu POTCARs exist, with different TITELs, and are all valid

@janosh janosh added io Input/output functionality fix Bug fix PRs vasp Vienna Ab initio Simulation Package labels Oct 10, 2023
Aaron Kaplan and others added 4 commits October 10, 2023 11:33
… but lives in the PBE official release; (ii) some POTCARs were updated in place with no version contrl (e.g., Eu and other lanthanides were updated in PBE releases but not renamed)
@janosh janosh merged commit c7e0355 into materialsproject:master Oct 10, 2023
22 checks passed
@janosh
Copy link
Member

janosh commented Oct 10, 2023

Just to leave a paper trail: this project of overhauling the pymatgen POTCAR validation to move away from hashes and towards checking several aggregations of numerical data in a POTCAR against reference values started in #3351, was updated in #3370 to support validating the latest 6.4 POTCARs and received this bug fix to make sure identically titled but numerically different POTCARs (of which VASP published ~20 in the original PBE POTCARs) all check out as valid.

We hope this is now productions ready. User feedback welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix PRs io Input/output functionality vasp Vienna Ab initio Simulation Package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants