Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept Path objects as filename in IStructure.to() #3553

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

janosh
Copy link
Member

@janosh janosh commented Jan 15, 2024

Closes #3551.

1a39d62 accept Path objects as filename in IStructure.to()
5afdf01 add test case for saving structure to pathlib.Path

@janosh janosh added io Input/output functionality fix Bug fix PRs core Pymatgen core labels Jan 15, 2024
@janosh janosh merged commit 2ec68d7 into master Jan 15, 2024
22 checks passed
@janosh janosh deleted the fix-gh-3551 branch January 15, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Pymatgen core fix Bug fix PRs io Input/output functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Structure.to() command fails if the filename keyword argument is of type Pathlib.Path
1 participant