Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix highly-nested parens when formula parsing in Composition #3569

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

janosh
Copy link
Member

@janosh janosh commented Jan 22, 2024

Closes #3559.

9896133 fix highly-nested formula parsing in Composition
aca351c add failure cases from gh-3559 as tests

@janosh janosh added fix Bug fix PRs core Pymatgen core labels Jan 22, 2024
@janosh janosh enabled auto-merge (squash) January 22, 2024 16:15
@janosh janosh merged commit e085343 into master Jan 22, 2024
22 checks passed
@janosh janosh deleted the fig-gh-3559-formula-parsing branch January 22, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Pymatgen core fix Bug fix PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in Parsing Complex Chemical Formulas with Parentheses in pymatgen's Composition Class
1 participant