Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert back TransformedStructure.__getattr__ #3617

Merged
merged 6 commits into from
Feb 10, 2024
Merged

Revert back TransformedStructure.__getattr__ #3617

merged 6 commits into from
Feb 10, 2024

Conversation

mjwen
Copy link
Member

@mjwen mjwen commented Feb 9, 2024 •
edited
Loading

Summary

Fix a recursion bug when using TransformedStructure.final_structure. Revert it back it original implementation. See example bug here: materialsproject/atomate2#707

Only the codes around line 90 of pymatgen/alchemy/materials.py are updated. Others are formatting by pre-commit.

This was referenced Feb 9, 2024
Closed
Merged
@Andrew-S-Rosen
Copy link
Member

Andrew-S-Rosen commented Feb 10, 2024 •
edited
Loading

(black was updated recently to the 2024 stable style. We'll probably be seeing a bunch of these trivial changes across the repo unless someone decides to run black . on the whole thing)

@janosh
Copy link
Member

janosh commented Feb 10, 2024 •
edited
Loading

@mjwen apologies for causing this bug and thanks for the fix! 👍

we now have a test case to guard against this in 0eb6d10

Others are formatting by pre-commit.

i assume you mean by your editor config? our pre-commit config no longer runs black

@janosh janosh added fix Bug fix PRs trafos Concerning transformation classes labels Feb 10, 2024
@janosh janosh enabled auto-merge (squash) February 10, 2024 07:27
@janosh janosh merged commit 12ab947 into materialsproject:master Feb 10, 2024
22 checks passed
@janosh janosh changed the title Revert back TransformedStructure.__getattr__ Revert back TransformedStructure.__getattr__ Feb 10, 2024
@utf utf mentioned this pull request Feb 15, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janosh janosh janosh approved these changes

@shyuep shyuep Awaiting requested review from shyuep shyuep is a code owner

@mkhorton mkhorton Awaiting requested review from mkhorton mkhorton is a code owner

Assignees
No one assigned
Labels
fix Bug fix PRs trafos Concerning transformation classes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mjwen @Andrew-S-Rosen @janosh