Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bader_analysis_from_path using warning as file path and reinstate test #3632

Merged
merged 2 commits into from Feb 17, 2024
Merged

Fix bader_analysis_from_path using warning as file path and reinstate test #3632

merged 2 commits into from Feb 17, 2024

Conversation

janosh
Copy link
Member

@janosh janosh commented Feb 17, 2024

closes #3631.

@janosh janosh added fix Bug fix PRs analysis Concerning pymatgen.analysis labels Feb 17, 2024
@janosh janosh enabled auto-merge (squash) February 17, 2024 09:15
@janosh janosh merged commit ff45527 into master Feb 17, 2024
22 checks passed
@janosh janosh deleted the fix-bader-from-path branch February 17, 2024 09:31
@Andrew-S-Rosen Andrew-S-Rosen mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyuep shyuep Awaiting requested review from shyuep shyuep is a code owner

@mkhorton mkhorton Awaiting requested review from mkhorton mkhorton is a code owner

Assignees
No one assigned
Labels
analysis Concerning pymatgen.analysis fix Bug fix PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bader_analysis_from_path misusing _get_filepath and hence not finding input VASP files
1 participant
@janosh