Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Subclass Construction Locpot<:VolumetricData #3639

Merged
merged 4 commits into from Feb 21, 2024

Conversation

jmmshn
Copy link
Contributor

@jmmshn jmmshn commented Feb 21, 2024

Subclass Construction Locpot<:VolumetricData

The constructor signature for Locpot is different from the parent.
This makes it hard to write general code to handle different kinds of VolumetricData objects.

Just adding a **kwarg there should work.

Copy link
Member

@janosh janosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at the risk of sounding pedantic, can we add a test for this?

@jmmshn
Copy link
Contributor Author

jmmshn commented Feb 21, 2024

No problem! The test I added passes with the new code but not the old code.

Copy link
Member

@janosh janosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jmmshn!

@janosh janosh enabled auto-merge (squash) February 21, 2024 19:19
@janosh janosh added io Input/output functionality vasp Vienna Ab initio Simulation Package api Application programming interface labels Feb 21, 2024
@janosh janosh merged commit 3f89175 into materialsproject:master Feb 21, 2024
22 checks passed
@janosh janosh added the fix Bug fix PRs label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Application programming interface fix Bug fix PRs io Input/output functionality vasp Vienna Ab initio Simulation Package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants