Remove properties from abivars dict as this breaks the interface with… #3642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janosh
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
sorry for the breakage @gmatteo and thanks for fixing. 🙏
not sure i fully understand this comment and why this prevents structure properties but since I'm not an abinit user and maybe shouldn't have messed with this code in the first place i'll take your word for it 😄
Properties are not supported if fmt="abivars" as its not a serialization protocol
|
we can make a new release once this and #3645 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @janosh , is it possible to merge this fix and make a new release of Pymatgen
as this bug breaks the interface with Abinit? Thanks