New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOBSTER IO improvements #3649
Merged
janosh
merged 15 commits into
materialsproject:master
from
naik-aakash:lobster_io_improvements
Feb 24, 2024
Merged
LOBSTER IO improvements #3649
janosh
merged 15 commits into
materialsproject:master
from
naik-aakash:lobster_io_improvements
Feb 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naik-aakash
requested review from
JaGeo,
shyuep,
janosh and
mkhorton
as code owners
February 23, 2024 13:44
…tgen into lobster_io_improvements remote sync
JaGeo
approved these changes
Feb 23, 2024
include value in ValueError msg
janosh
added
enhancement
A new feature or improvement to an existing one
io
Input/output functionality
ux
User experience
lobster
Lobster package (Local Orbital Basis Suite Towards Electronic-Structure Reconstruction)
labels
Feb 24, 2024
janosh
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
A new feature or improvement to an existing one
io
Input/output functionality
lobster
Lobster package (Local Orbital Basis Suite Towards Electronic-Structure Reconstruction)
ux
User experience
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes