Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove exception printing when importing phonopy #3696

Merged
merged 1 commit into from Mar 20, 2024

Conversation

lan496
Copy link
Contributor

@lan496 lan496 commented Mar 19, 2024

Summary

Removes stdout printing when trying to import phonopy for tidiness. These printing appeared in some downstream packages. For example

pip install mp_api
python -c "from mp_api.client import MPRester"

resulted in

No module named 'phonopy'
No module named 'phonopy'

Checklist

  • Google format doc strings added. Check with ruff.
  • Type annotations included. Check with mypy.
  • Tests added for new features/fixes.
  • If applicable, new classes/functions/modules have duecredit @due.dcite decorators to reference relevant papers by DOI (example)

Tip: Install pre-commit hooks to auto-check types and linting before every commit:

pip install -U pre-commit
pre-commit install

@lan496
Copy link
Contributor Author

lan496 commented Mar 19, 2024

@janosh janosh added housekeeping Linting fixes, cleaning up and refactoring code ux User experience labels Mar 20, 2024
Copy link
Member

@janosh janosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @lan496.

The CI jobs seem to be failed due to network timeouts.

should be fixed by 2dbe219

@janosh janosh added the phonon Lattice vibrations label Mar 20, 2024
@janosh janosh merged commit 83e7eea into materialsproject:master Mar 20, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Linting fixes, cleaning up and refactoring code phonon Lattice vibrations ux User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants