Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Self type in Method Signatures #3705

Merged
merged 84 commits into from
Mar 29, 2024
Merged

Use Self type in Method Signatures #3705

merged 84 commits into from
Mar 29, 2024

Commits on Mar 24, 2024

  1. add some Self type annotations

    @DanielYang59
    DanielYang59 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    4355dec View commit details
    Browse the repository at this point in the history

  2. add more Self and type annotations

    @DanielYang59
    DanielYang59 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    7130241 View commit details
    Browse the repository at this point in the history

  3. add more Self and type annotations

    @DanielYang59
    DanielYang59 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    b7cc248 View commit details
    Browse the repository at this point in the history

  4. pre-commit auto-fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    a467a2e View commit details
    Browse the repository at this point in the history

  5. add more Self and type annotations

    @DanielYang59
    DanielYang59 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    ae6f09a View commit details
    Browse the repository at this point in the history

  6. Merge branch 'use-self-type' of github.com:DanielYang59/pymatgen into… 

    … use-self-type
    @DanielYang59
    DanielYang59 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    4fb2035 View commit details
    Browse the repository at this point in the history

  7. format docstring to google style

    @DanielYang59
    DanielYang59 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    e0c1366 View commit details
    Browse the repository at this point in the history

  8. add more Self types

    @DanielYang59
    DanielYang59 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    cc49d0b View commit details
    Browse the repository at this point in the history

  9. TEMP FIX for normalized repr

    @DanielYang59
    DanielYang59 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    1938cb9 View commit details
    Browse the repository at this point in the history

  10. add more Self types

    @DanielYang59
    DanielYang59 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    2e7921f View commit details
    Browse the repository at this point in the history

  11. remove encoding for binary

    @DanielYang59
    DanielYang59 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    b06bc89 View commit details
    Browse the repository at this point in the history

  12. use Attributes over Parameters

    @DanielYang59
    DanielYang59 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    48a8fd5 View commit details
    Browse the repository at this point in the history

  13. add Self return type to __new__ and __enter__ methods

    @janosh
    janosh committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    2adde29 View commit details
    Browse the repository at this point in the history

  14. use Self for multi-line def

    @DanielYang59
    DanielYang59 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    296fe08 View commit details
    Browse the repository at this point in the history

  15. Merge branch 'use-self-type' of https://github.com/DanielYang59/pymatgen 

     into use-self-type
    @DanielYang59
    DanielYang59 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    5994121 View commit details
    Browse the repository at this point in the history

  16. mypy fixes in core

    @DanielYang59
    DanielYang59 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    5b58fbc View commit details
    Browse the repository at this point in the history

  17. mypy fixes in core

    @DanielYang59
    DanielYang59 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    13dbbd9 View commit details
    Browse the repository at this point in the history

  18. move mypy fixes

    @DanielYang59
    DanielYang59 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    949af29 View commit details
    Browse the repository at this point in the history

  19. Merge branch 'master' into use-self-type

    @DanielYang59
    DanielYang59 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    0eda046 View commit details
    Browse the repository at this point in the history

  20. add Note tag

    @DanielYang59
    DanielYang59 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    bd08e71 View commit details
    Browse the repository at this point in the history

  21. Merge branch 'use-self-type' of https://github.com/DanielYang59/pymatgen 

     into use-self-type
    @DanielYang59
    DanielYang59 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    91ae376 View commit details
    Browse the repository at this point in the history

  22. remove unused arg properties from core.ion

    @DanielYang59
    DanielYang59 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    11a53c4 View commit details
    Browse the repository at this point in the history

  23. fix mypy error

    @DanielYang59
    DanielYang59 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    493bc75 View commit details
    Browse the repository at this point in the history

  24. fix unit test for reaction energy calc

    @DanielYang59
    DanielYang59 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    0aba332 View commit details
    Browse the repository at this point in the history

  25. fix unit test for core.units

    @DanielYang59
    DanielYang59 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    47a7c22 View commit details
    Browse the repository at this point in the history

  26. remove ERROR = UnitError

    @DanielYang59
    DanielYang59 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    6a705d2 View commit details
    Browse the repository at this point in the history

  27. google-style doc string return type format

    @janosh
    janosh committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    ea76e15 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. replace deprecated utcnow

    @DanielYang59
    DanielYang59 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    b528903 View commit details
    Browse the repository at this point in the history

  2. fix missing datetime import

    @DanielYang59
    DanielYang59 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    86a2d9f View commit details
    Browse the repository at this point in the history

  3. replace app = lines.append

    @DanielYang59
    DanielYang59 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    fa05c87 View commit details
    Browse the repository at this point in the history

  4. slab type hints

    @janosh
    janosh committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    6d789e5 View commit details
    Browse the repository at this point in the history

  5. relocate Slab import

    @DanielYang59
    DanielYang59 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    e8b6eb7 View commit details
    Browse the repository at this point in the history

  6. fix vector in adsorption

    @DanielYang59
    DanielYang59 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    df224a9 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into use-self-type

    @DanielYang59
    DanielYang59 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    b12eadb View commit details
    Browse the repository at this point in the history

  8. use time for time count

    @DanielYang59
    DanielYang59 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    1263036 View commit details
    Browse the repository at this point in the history

  9. revert datetime utc

    @DanielYang59
    DanielYang59 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    5a75503 View commit details
    Browse the repository at this point in the history

  10. switch to time

    @DanielYang59
    DanielYang59 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    7df2bfe View commit details
    Browse the repository at this point in the history

  11. switch to datetime for utc time for now

    @DanielYang59
    DanielYang59 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    bd72454 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'master' into pr/DanielYang59/3705

    @janosh
    janosh committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    b8f1a32 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. take some coderabbitai suggestions

    @DanielYang59
    DanielYang59 committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    da7fded View commit details
    Browse the repository at this point in the history

  2. ignore some mypy override errors

    @DanielYang59
    DanielYang59 committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    1595cf2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into use-self-type

    @DanielYang59
    DanielYang59 committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    3381b53 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into use-self-type

    @DanielYang59
    DanielYang59 committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    6f397bb View commit details
    Browse the repository at this point in the history

  5. fix type ufloat

    @DanielYang59
    DanielYang59 committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    f96ccfb View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. fix BaseLammpsGenerator missing fields inputfile and data (did this a… 

    …ctually work before) plus fix mypy errors
    @janosh
    janosh committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    8583e39 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into pr/DanielYang59/3705

    @janosh
    janosh committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    42ade92 View commit details
    Browse the repository at this point in the history

  3. mypy fixes

    @DanielYang59
    DanielYang59 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    3bb711d View commit details
    Browse the repository at this point in the history

  4. mypy fixes

    @DanielYang59
    DanielYang59 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    48abd6f View commit details
    Browse the repository at this point in the history

  5. more mypy fixes

    @DanielYang59
    DanielYang59 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    5923a55 View commit details
    Browse the repository at this point in the history

  6. mypy fixes 

    down to 69 errors
    @janosh
    janosh committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    bc47741 View commit details
    Browse the repository at this point in the history

  7. fix unit test

    @DanielYang59
    DanielYang59 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    7b82274 View commit details
    Browse the repository at this point in the history

  8. fix unit test

    @DanielYang59
    DanielYang59 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    1d11b0e View commit details
    Browse the repository at this point in the history

  9. reapply fix for voronoi

    @DanielYang59
    DanielYang59 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    6973596 View commit details
    Browse the repository at this point in the history

  10. fix mypy and voronoi unit test

    @DanielYang59
    DanielYang59 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    1a9878d View commit details
    Browse the repository at this point in the history

  11. fix unit test for voronoi

    @DanielYang59
    DanielYang59 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    d8f4877 View commit details
    Browse the repository at this point in the history

  12. more mypy fixes

    @DanielYang59
    DanielYang59 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    8e10c9d View commit details
    Browse the repository at this point in the history

  13. one more mypy fix

    @DanielYang59
    DanielYang59 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    13e1eed View commit details
    Browse the repository at this point in the history

  14. pre-commit auto-fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    d69e1ad View commit details
    Browse the repository at this point in the history

  15. fix number import name

    @DanielYang59
    DanielYang59 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    f9a0b65 View commit details
    Browse the repository at this point in the history

  16. fix lammps generator

    @DanielYang59
    DanielYang59 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    2d5e0bb View commit details
    Browse the repository at this point in the history

  17. avoid self type hard-coding

    @DanielYang59
    DanielYang59 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    5d88bc3 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. mypy fix

    @DanielYang59
    DanielYang59 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    934934a View commit details
    Browse the repository at this point in the history

  2. sourcery fix

    @DanielYang59
    DanielYang59 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    cf16f8b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into use-self-type

    @DanielYang59
    DanielYang59 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    4d76b1f View commit details
    Browse the repository at this point in the history

  4. sourcery fix

    @DanielYang59
    DanielYang59 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    5cd6072 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'use-self-type' of github.com:DanielYang59/pymatgen into… 

    … use-self-type
    @DanielYang59
    DanielYang59 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    3efde4c View commit details
    Browse the repository at this point in the history

  6. sourcery fix

    @DanielYang59
    DanielYang59 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    8cdbed9 View commit details
    Browse the repository at this point in the history

  7. mypy fix

    @DanielYang59
    DanielYang59 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    fdf428d View commit details
    Browse the repository at this point in the history

  8. suppress mypy error

    @DanielYang59
    DanielYang59 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    b0d63cd View commit details
    Browse the repository at this point in the history

  9. mypy and sourcery fix

    @DanielYang59
    DanielYang59 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    96f285a View commit details
    Browse the repository at this point in the history

  10. mypy fixes

    @DanielYang59
    DanielYang59 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    3b293bf View commit details
    Browse the repository at this point in the history

  11. fix unit tests

    @DanielYang59
    DanielYang59 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    7312432 View commit details
    Browse the repository at this point in the history

  12. mypy fixes

    @DanielYang59
    DanielYang59 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    7e426bd View commit details
    Browse the repository at this point in the history

  13. mypy fixes

    @DanielYang59
    DanielYang59 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    f9107fb View commit details
    Browse the repository at this point in the history

  14. suppress mypy error in xcfunc

    @DanielYang59
    DanielYang59 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    fb49e75 View commit details
    Browse the repository at this point in the history

  15. fix mypy error

    @DanielYang59
    DanielYang59 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    5e22d01 View commit details
    Browse the repository at this point in the history

  16. fix mypy error

    @DanielYang59
    DanielYang59 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    cfd77ab View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. refactor date parsing in AirssProvider to use std lib datetime instea… 

    …d of pypi pkg dateutil
    @janosh
    janosh committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    a1e8eb0 View commit details
    Browse the repository at this point in the history

  2. fix TestKpoints check kpts_shift

    @janosh
    janosh committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    8137931 View commit details
    Browse the repository at this point in the history

  3. fix mypy error in sets.py: cast(Sequence[Sequence[float]], kpoints)

    @janosh
    janosh committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    4bbee19 View commit details
    Browse the repository at this point in the history

  4. refactor

    @janosh
    janosh committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    8bdb484 View commit details
    Browse the repository at this point in the history

  5. fix mypy confusing keyword and positional args in Lattice.from_parame… 

    …ters
    @janosh
    janosh committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    6d06bef View commit details
    Browse the repository at this point in the history

  6. remove now unused mypy ignore in Cssr.from_str

    @janosh
    janosh committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    5c309e3 View commit details
    Browse the repository at this point in the history

  7. fix bad refactor in 8bdb484

    @janosh
    janosh committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    2fe3b93 View commit details
    Browse the repository at this point in the history