Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some of the OPTIMADE aliases #3754

Merged

Conversation

ml-evs
Copy link
Contributor

@ml-evs ml-evs commented Apr 12, 2024

cf #3753, this PR fixes some of the broken OPTIMADE aliases.

Summary by CodeRabbit

  • New Features
    • Updated the OptimadeRester with new database aliases for enhanced connectivity options, including "alexandria", "odbx", "odbx.gnome", "alexandria.pbe", and "alexandria.pbesol".

Copy link

coderabbitai bot commented Apr 12, 2024

Walkthrough

The OptimadeRester class has been enhanced with additional database aliases, expanding its connectivity to new endpoints like "alexandria", "odbx", and "odbx.gnome". This update also introduces specific aliases for different computational methods within the "alexandria" database, namely "pbe" and "pbesol".

Changes

File Change Summary
.../ext/optimade.py Added aliases for "alexandria", "odbx", "odbx.gnome", "alexandria.pbe", and "alexandria.pbesol" endpoints

🐇✨
In the code's woven maze, a rabbit hops,
Adding paths where data never stops.
Alexandria's gates, ODBX streams,
Through lines of code, a developer dreams.
🌟🌌


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between f81535f and d07e76c.
Files selected for processing (1)
  • pymatgen/ext/optimade.py (2 hunks)
Additional comments not posted (2)
pymatgen/ext/optimade.py (2)

55-57: The new aliases for "alexandria", "alexandria.pbe", and "alexandria.pbesol" are correctly added with distinct and appropriate URLs.


76-76: The new alias for "odbx.gnome" is correctly added with an appropriate URL.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ml-evs
Copy link
Contributor Author

ml-evs commented Apr 12, 2024

@coderabbitai disable

Copy link

coderabbitai bot commented Apr 12, 2024

@ml-evs, I'm disabling the automated reviews for this pull request as requested. If you need to resume reviews or have any other requests, feel free to let me know!

Actions performed

Reviews paused.

@janosh
Copy link
Member

janosh commented Apr 13, 2024

Just to clarify, this does not fix the "mcloud.mc3d" provider, so @JaGeo's issue should remain open?

didn't see the discussion in #3753 about the issue not reproducing

@janosh janosh added fix Bug fix PRs ext pymatgen ext package for API data fetching labels Apr 13, 2024
@janosh janosh merged commit 9aacf65 into materialsproject:master Apr 13, 2024
22 checks passed
@ml-evs
Copy link
Contributor Author

ml-evs commented Apr 13, 2024

Just to clarify, this does not fix the "mcloud.mc3d" provider, so @JaGeo's issue should remain open?

didn't see the discussion in #3753 about the issue not reproducing

It does repro, I was just doing it badly late on a Friday evening ;) I'll try to cook up a fix (I think this came up once before)

@ml-evs
Copy link
Contributor Author

ml-evs commented Apr 13, 2024

How does calendar versioning work when you need to do another fix on the same day? 😁

@janosh
Copy link
Member

janosh commented Apr 13, 2024

It doesn't. I guess you could add a -1 suffix. Still one of several reasons calendar versioning is inferior to semantic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext pymatgen ext package for API data fetching fix Bug fix PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants