Fix for incorrect file path in tests/io/test_zeopp.py
#3784
Conversation
WalkthroughThe changes involve enhancing parameter descriptions, improving code readability, and updating file paths for better organization and accessibility within the codebase across multiple files in different directories. Changes
Recent Review DetailsConfiguration used: .coderabbit.yaml Files selected for processing (1)
Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
janosh
added
tests
There was a problem hiding this comment.
thanks for the fix @AntObi! 👍
@DanielYang59 if you have time, could you see if there might be any other skipped tests where the test file path was not updated during the file migrations in #3746
…rs instead of percent format
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| @@ -4291,8 +4291,7 @@ def perturb(self, distance: float, min_distance: float | None = None) -> Self: | |||
| symmetries. Modifies the structure in place. | |||
|
|
|||
| Args: | |||
| distance (float): Distance in angstroms by which to perturb each | |||
| site. | |||
| distance (float): Distance in angstroms by which to perturb each site. | |||
There was a problem hiding this comment.
Clarify the parameter description for the distance argument in the perturb method.
Summary
I've been testing using
Zeo++with pymatgen usingio/zeoppand found that some of the tests were failing. I've determined that the tests were failing due to incorrect file paths to the tests files.Major changes: Fixed incorrect file path in zeopp test file
f"{TEST_FILES_DIR}/cssr/EDI.cssr"->f"{TEST_FILES_DIR}/io/cssr/EDI.cssr"f"{TEST_FILES_DIR}/cssr/EDI_oxistate_decorated.cssr"->f"{TEST_FILES_DIR}/io/cssr/EDI_oxistate_decorated.cssr"Checklist
ruff.mypy.duecredit@due.dcitedecorators to reference relevant papers by DOI (example)Tip: Install
pre-commithooks to auto-check types and linting before every commit: