Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filter condition for warn msg of unphysical site occupancy in io.cif #3853

Merged
merged 5 commits into from
Jun 3, 2024
Merged

Fix filter condition for warn msg of unphysical site occupancy in io.cif #3853

merged 5 commits into from
Jun 3, 2024

Conversation

DanielYang59
Copy link
Contributor

@DanielYang59 DanielYang59 commented Jun 1, 2024 •
edited
Loading

Summary

@DanielYang59 DanielYang59 marked this pull request as ready for review June 1, 2024 15:11
@DanielYang59
Copy link
Contributor Author

DanielYang59 commented Jun 1, 2024 •
edited
Loading

@janosh I pushed this hot fix to address the error message issue

@DanielYang59 DanielYang59 changed the title Fix filter condition in io.cif Fix filter condition for warn msg of unphysical site occupancy in io.cif Jun 2, 2024
@janosh janosh added fix Bug fix PRs cif Crystallographic information file tests Issues with or changes to the pymatgen test suite labels Jun 3, 2024
janosh
janosh approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@janosh janosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the timely fix @DanielYang59! 👍

@janosh janosh enabled auto-merge (squash) June 3, 2024 16:10
@janosh janosh merged commit 1a5af18 into materialsproject:master Jun 3, 2024
23 checks passed
@DanielYang59 DanielYang59 deleted the fix-io-cif-err-msg branch June 4, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janosh janosh janosh approved these changes

@shyuep shyuep Awaiting requested review from shyuep shyuep is a code owner

@mkhorton mkhorton Awaiting requested review from mkhorton mkhorton is a code owner

Assignees
No one assigned
Labels
cif Crystallographic information file fix Bug fix PRs tests Issues with or changes to the pymatgen test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DanielYang59 @janosh