Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI run without 'optional' deps installed #3857

Merged
merged 9 commits into from
Jun 3, 2024
Merged

Conversation

janosh
Copy link
Member

@janosh janosh commented Jun 3, 2024

addresses the underlying cause of why the issue reported by @kavanase in #3752 (comment) was only caught after pypi release

…xtras: '' to test pymatgen without any optional deps installed
@janosh janosh added tests Issues with or changes to the pymatgen test suite ci Continuous integration pkg Package health and distribution related stuff ecosystem Concerning the larger pymatgen ecosystem labels Jun 3, 2024
@janosh janosh changed the title Add CI run to test pymatgen without any 'optional' deps installed Add CI run without 'optional' deps installed Jun 3, 2024
f-strings, better var names, fix ruff RUF002
@janosh janosh enabled auto-merge (squash) June 3, 2024 19:03
@janosh janosh merged commit d1fac20 into master Jun 3, 2024
33 checks passed
@janosh janosh deleted the ci-only-required-deps branch June 3, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration ecosystem Concerning the larger pymatgen ecosystem pkg Package health and distribution related stuff tests Issues with or changes to the pymatgen test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant