Fix get_reconstructed_band_structure method #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are failing tests due to tabs. Pls fix. Thanks. |
|
Ok, this has been fixed. Apologies for the messy commit history. |
gmatteo
added a commit
to gmatteo/pymatgen
that referenced
this pull request
Jan 15, 2018
* 'master' of https://github.com/materialsproject/pymatgen: Bug fix in task.reset (materialsproject#995) Thermodynamic properties from phonon DOS (materialsproject#996) Fix get_reconstructed_band_structure method (materialsproject#992)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use numpy concatenate function to fix the
pymatgen.electronic_structure.bandstructure.get_reconstructed_band_structure()function.Fixes #543
I've also added a basic test to ensure this method is not broken in the future.