-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make MigrationHop MSONable again #312
Conversation
Pls fix the test errors. The linting errors can be dealt with later, but the unittest must pass. |
for more information, see https://pre-commit.ci
Pls merge the latest master. A lot of the problems will disappear. |
@shyuep the test I added (pymatgen/analysis/diffusion/tests/test_pathfinder.py::PathfinderTest::test_mhop_msonable) now passes. Are any other changes needed? |
The tests fail because there are changes in your PR with host_symm_structure. These need to be fixed. |
Pull Request Test Coverage Report for Build 2713423963
💛 - Coveralls |
@shyuep would it be possible to release an updated version of pymatgen-analysis-diffusion with this change on PyPi? I am working on code in emmet that depends on this patch. |
Done. |
Great! Thank you so much @shyuep for your responsiveness in getting this fix addressed in a timely manner. |
Taking over a previous pull request that was abandoned: #264