Start with env variables from Configuration with Debug/Non Debug mode. #62
Conversation
There was a problem hiding this comment.
Thanks again for the contribution, @thienpow we are getting there.
I have tested the code locally and left a couple of other observations.
The more important ones are :
-
that the user and password should consider command-line parameters and env var before stopping the execution.
-
In the disk ops, we are building the config object all the time to pick a single property that we need.
I have made some changes to this PR; please pull from thienpow-master before pushing the new changes.
src/lib/configuration.rs
Outdated
| nun_tcp_addr: expect_env_var("NUN_HTTP_ADDR", "0.0.0.0:3014"), | ||
| nun_replicate_addr: expect_env_var("NUN_REPLICATE_ADDR", ""), | ||
| nun_log_level: expect_env_var("NUN_LOG_LEVEL", "Info"), //(Off, Error, Warn, Info, Debug, Trace) | ||
| nun_log_dir: expect_env_var("NUN_LOG_DIR", "/tmp/data/nun_db/log"), |
There was a problem hiding this comment.
This is not used anywhere, are you planning to add this to some other part of the code?
There was a problem hiding this comment.
yeah will hunt down where they should be in the codes and add more for the snapshot thing later.
src/lib/configuration.rs
Outdated
|
|
||
| #[test] | ||
| fn run_mode_should_get_empty_but_debug_mode_got_value() { | ||
| let config = get_configuration(); |
There was a problem hiding this comment.
interesting approach with the test...
| ws_address: &str, | ||
| http_address: &str, | ||
| tcp_address: &str, |
There was a problem hiding this comment.
bcos 3012,3013,3014...
src/lib/disk_ops.rs
Outdated
| Some(dir_name) => dir_name.into_string().unwrap(), | ||
| None => DIR_NAME.to_string(), | ||
| } | ||
| get_configuration().nun_dbs_dir |
There was a problem hiding this comment.
Here we are building the config object with several props and keys to use one... we should find a better way to build it only once
There was a problem hiding this comment.
maybe can try lazy_static crate... later i try.
There was a problem hiding this comment.
now is using lazy_static @mateusfreira can take a look
src/main.rs
Outdated
| init_logger(); | ||
| let config = configuration::get_configuration(); | ||
|
|
||
| if config.nun_user.as_str() == "" || config.nun_pwd == "" { |
There was a problem hiding this comment.
This is problematic because, because user and PWD can also be provided via command line parameter
There was a problem hiding this comment.
so the priority is command line then env... will put that into a startup_condition_check function
mateusfreira
changed the base branch from
master
to
contralize-configuration
No description provided.