Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 6 Maintainability issues in multiple files #12

Closed
matfax opened this issue Oct 20, 2019 · 0 comments
Closed

Fix 6 Maintainability issues in multiple files #12

matfax opened this issue Oct 20, 2019 · 0 comments

Comments

@matfax
Copy link
Owner

matfax commented Oct 20, 2019

CodeFactor found multiple issues:

Unnecessary "else" after "return"

mutapath\decorator.py:84
Commit a2e0cd1

Unnecessary "elif" after "return"

mutapath\decorator.py:86
Commit 4a9cf29

Unnecessary pass statement

mutapath\lock_dummy.py:20
Commit a2e0cd1
mutapath\lock_dummy.py:16
Commit a2e0cd1
mutapath\lock_dummy.py:12
Commit a2e0cd1
mutapath\lock_dummy.py:8
Commit a2e0cd1
matfax added a commit that referenced this issue Oct 20, 2019
@matfax
fix(issue): issue #12
8234c09
matfax added a commit that referenced this issue Oct 20, 2019
@matfax
feat: Integrate Pathlib Attributes (#11)
5f18c45 
* The chained attribute accessors are now using `path.Path` and now additionally `pathlib.Path` as fallback. This grants wider compatibility with both libraries.

* `Path.glob` uses the mechanism from `pathlib.Path.glob` now, instead of `path.Path.glob` because it is confusing that `path.Path.glob` does not accept the same recursive `**` wildcards.

* Chained properties are now implicitly fetched.

* All chained iterator returns are now converted to generators if they are no lists or strings.

* fix(issue): improving maintainability, closing #12
@matfax matfax closed this as completed Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matfax