saturate instances on structure declaration #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gares
commented
Feb 16, 2023
gares
commented
Feb 16, 2023
|
don't forget to undup the list of types. |
gares
commented
Mar 1, 2023
gares
commented
Mar 31, 2023
gares
commented
May 22, 2023
|
I'm reviving this since we really need it in the contest of coreact. |
|
I'll rebase on top of master and then force push. |
gares
force-pushed
the
instance-before-structure
branch
from
edaff8d
to
198ce25
Compare
|
@ThomasPortet do you mind if I squash the history? There are so many changes on the same lines that rebasing other work on this PR is quite tedious. As I was saying this PR is really needed for the Coreact project, and we need to rebase our work there on this one. Then I think I can merge and maybe open a few issues for some of the TODOs so that we don't forget about them. |
|
@CohenCyril I need you help, I'd like to run CI on math-comp and co, but here it succeeds super fast. I've the impression it is not using this branch of HB. |
gares
commented
Oct 8, 2023
gares
commented
Oct 8, 2023
gares
commented
Oct 8, 2023
gares
commented
Oct 8, 2023
This was referenced Oct 8, 2023
When a new structure `S` is created it may be the case that some type which is already equipped with some mixins is an instance of `S`, but was not declared as such since `S` was not declared yet. Similarly, mixin instances which have parameters may not be available on a single type until there is a structure for the parameter which is rich enough. We store in the predicate `has-mixin-instance` the list of types which have mixin instances, so that we can reconsider them later. Out of these we craft `mixin-src` clauses (used by `HB/common/inference.elpi`) which have premises using Coq's unifyer (which in turn can compute the smallest structure having all requirements thanks to the hints we declare on joins). Example: When such an instance is declared: ```coq HB.instance Definition I1 (X:t1) : mixin1 (list X) := ... . ``` a clause of this form is generated: ```coq has-mixin-instance (cs-gref (indt «list»)) (indt «mixin1.axioms_») (const «I1») ``` When `HB.saturate` is called, we generate conditional `mixin-src` clauses with conditions on parameters (via the function `has-mixin-instance->mixin-src`). Then for each type constructor mentioned in a `has-mixin-src` clause we try to declare new instances with the new clauses via `declare-all-on-type-constructor`. Unresolved parameters are abstracted out. Their type is the smallest structure which can satisfy all the constraints coming from single mixins.
gares
force-pushed
the
instance-before-structure
branch
from
df1f03d
to
81cdb25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #197