Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website coqdoc outdated / release process incomplete #361

Closed
gares opened this issue Jun 21, 2019 · 25 comments
Closed

website coqdoc outdated / release process incomplete #361

gares opened this issue Jun 21, 2019 · 25 comments
Assignees

Comments

@gares
Copy link
Member

gares commented Jun 21, 2019

At some point @maximedenes made the website available at https://math-comp.github.io/ but the release process documented at https://github.com/math-comp/math-comp/wiki/Howto-Release misses a step to synchronize the websites (since the authoritative contents are still in the .../math-comp/ repo I guess).

@gares
Copy link
Member Author

gares commented Jul 1, 2019

CC @CohenCyril @affeldt-aist Ping @maximedenes

@gares
Copy link
Member Author

gares commented Jul 1, 2019

FTR, the website at http://math-comp.github.io/math-comp/ has the update coqdoc, while the one at https://math-comp.github.io/ has not!

@affeldt-aist
Copy link
Member

I didn't realize the website was duplicated.

@gares
Copy link
Member Author

gares commented Jul 1, 2019

it's a bug ;-)

@CohenCyril
Copy link
Member

Should we take down http://math-comp.github.io/math-comp/ or keep it as a documentation-specific website?

@CohenCyril
Copy link
Member

CohenCyril commented Jul 2, 2019

PS: Many links (papers, website, posts, chat messages) might still reference http://math-comp.github.io/math-comp/ as the main page, so I advocate we keep the page alive but re-purpose it as I said. What do you think?

@amahboubi
Copy link
Member

I think that keeping the two is a bad idea, because it will be too confusing for both users and maintainers of the website.

Can't we just redirect http://math-comp.github.io/math-comp/ to http://math-comp.github.io?

@CohenCyril
Copy link
Member

Can't we just redirect http://math-comp.github.io/math-comp/ to http://math-comp.github.io?

yes I think we can

@amahboubi
Copy link
Member

amahboubi commented Jul 2, 2019

Great! Yet this redirection topic is slightly different from the one of the present issue, which is about the bad version of the documentation linked from http://math-comp.github.io.

CohenCyril added a commit that referenced this issue Jul 2, 2019
Merge only after solving issue #361
@amahboubi
Copy link
Member

Ping @maximedenes .

@maximedenes
Copy link
Contributor

Sorry for this confusing situation. Can you clarify what you want me to do?

@amahboubi
Copy link
Member

amahboubi commented Jul 5, 2019

Today the coqdoc documentation linked from the new location of the website is outdated. E.g.:
https://math-comp.github.io/htmldoc/mathcomp.ssreflect.ssreflect.html
The one in sync lives at the previous location. E.g.:
http://math-comp.github.io/math-comp/htmldoc/mathcomp.ssreflect.ssreflect.html

Actions needed:

  1. repair
  2. update the release instructions so that this does not happen anymore
  3. Redirect http://math-comp.github.io/math-comp/ to http://math-comp.github.io

Point 3 is addressed by #365 but points 1 and 2 are not done, and should precede 3.

@maximedenes
Copy link
Contributor

Working on 1.

For 2., I'll need to discuss with @gares how to separate concerns between math-comp proper and the website. The current html doc build script does very strange things, including mangling source files in place without warning... Not sure I can write reliable and reasonable release instructions with this state of affairs.

@amahboubi
Copy link
Member

amahboubi commented Jul 5, 2019

Working on 1.

Many thanks @maximedenes !

@maximedenes
Copy link
Contributor

Wait! @gares didn't your import-doc Makefile target already address this?

https://github.com/math-comp/math-comp.github.io/blob/master/Makefile

The file header is a bit terse.

@maximedenes
Copy link
Contributor

including mangling source files in place without warning

And of course it is not idempotent. So I got incorrect results, and will need to rebuild math comp entirely. Please bear with me.

@gares
Copy link
Member Author

gares commented Jul 5, 2019

https://github.com/math-comp/math-comp.github.io/blob/master/Makefile

This should be dropped (it was used when we could not release by tagging master).

including mangling source files in place without warning... Not sure I can write reliable and reasonable release instructions with this state of affairs.

The Makefile in https://github.com/math-comp/math-comp/blob/master/docs/htmldoc/Makefile is idempotent when it succeeds (it checks your tree is clean and uses git to restore the old files at the end).

If you move the Makefile elsewhere you could get in input the git url to clone (a tag for the release, a branch for testing things)

@maximedenes
Copy link
Contributor

The Makefile in https://github.com/math-comp/math-comp/blob/master/docs/htmldoc/Makefile is idempotent when it succeeds (it checks your tree is clean and uses git to restore the old files at the end).

Yeah but a successful build is typically one you don't restart, whereas failing ones...

@maximedenes
Copy link
Contributor

If you move the Makefile elsewhere you could get in input the git url to clone (a tag for the release, a branch for testing things)

Yes, I think that's what we should do (although not sure it should be a Makefile). This way we could solve both problems, by working on a temporary copy of the repo (no modification in place) and not relying on the doc and the sources being in the same repo.

@gares
Copy link
Member Author

gares commented Jul 5, 2019

It leaves you the thing that did not compile, so that you can inspect it. I really don't get what the problem is.

@maximedenes
Copy link
Contributor

It leaves you the thing that did not compile, so that you can inspect it. I really don't get what the problem is.

The problem (IIUC) is that when you fix the problem and relaunch the build, it will mangle the sources more, and you get formatting issues in the final html.

@gares
Copy link
Member Author

gares commented Jul 5, 2019

Then the check must be incomplete (since I guess you did not commit the mangled sources).
The script should just refuse to run if the sources are already mangled (it could be smarter, but this is not the problem here). Why does not it stop saying you have uncommitted changes?

@maximedenes
Copy link
Contributor

Yes, the test is broken. We are discussing it in the other thread.

Anyway, it seems I finally got the updated HTML documentation. Will create a PR.

@maximedenes
Copy link
Contributor

@amahboubi For 1., see math-comp/math-comp.github.io#7

@amahboubi
Copy link
Member

Very good, thanks! One last thing regarding 1 and 3. As far as I can see, we now how two versions of the coqdoc,e.g.:
https://math-comp.github.io/htmldoc/mathcomp.ssreflect.ssreflect.html
and
http://math-comp.github.io/math-comp/htmldoc/mathcomp.ssreflect.ssreflect.html

Today, there are identical, but will they stay so? Can we either remove the 2nd one, or redirect to the first? It seems to me that #365 only addresses the re-direction of the root of the site. @CohenCyril can you confirm?

CohenCyril added a commit to CohenCyril/math-comp that referenced this issue Jul 18, 2019
Merge only after solving issue math-comp#361
CohenCyril added a commit that referenced this issue Oct 16, 2019
Merge only after solving issue #361
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants