Adding keywords in OPAM files #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I only added keywords for ssreflect and algebra as I feel a lot less qualified about fingroup, solvable, field and character. |
CohenCyril
reviewed
Nov 22, 2023
|
@amahboubi your name was mentionned during the last meeting https://github.com/math-comp/math-comp/wiki/Minutes-November-22-2023 as our expert on character. If you want to add some keywords for that part, it would be great. Otherwise no worry this could still be merged as is. |
|
Nothing happened since end of November, let's merge as it is. We can still add more later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add keywords in OPAM files.
Following last meeting https://github.com/math-comp/math-comp/wiki/Minutes-November-08-2023#adding-more-keywords-in-opam-file
Cc @CohenCyril @Tragicus @affeldt-aist @ybertot @pi8027 @gares who attended the meeting
Things done/to do
added corresponding entries inCHANGELOG_UNRELEASED.mdadded corresponding documentation in the headersCompatibility with MathComp 1.X
TODO: MC-1 portto make sure someone ports this PR tothe
mathcomp-1branch or I already opened an issue or PR (please cross reference).Automatic note to reviewers
Read this Checklist and put a milestone if possible.